Re: call ber_read() from ber_getc() in ldap, ldapd, and ypldap

2018-07-03 Thread Claudio Jeker
On Tue, Jul 03, 2018 at 05:38:18PM -0400, Rob Pierce wrote: > On Tue, Jul 03, 2018 at 09:25:06PM +0100, Stuart Henderson wrote: > > On 2018/07/03 22:17, Claudio Jeker wrote: > > > I have a hard time to understand why this is needed in snmpd. > > > For single char reads ber_readbuf(b, c, 1) and

Re: call ber_read() from ber_getc() in ldap, ldapd, and ypldap

2018-07-03 Thread Rob Pierce
On Tue, Jul 03, 2018 at 09:25:06PM +0100, Stuart Henderson wrote: > On 2018/07/03 22:17, Claudio Jeker wrote: > > I have a hard time to understand why this is needed in snmpd. > > For single char reads ber_readbuf(b, c, 1) and ber_read(b, c, 1) should do > > exaclty the same. At least in the old

Re: call ber_read() from ber_getc() in ldap, ldapd, and ypldap

2018-07-03 Thread Stuart Henderson
On 2018/07/03 22:17, Claudio Jeker wrote: > I have a hard time to understand why this is needed in snmpd. > For single char reads ber_readbuf(b, c, 1) and ber_read(b, c, 1) should do > exaclty the same. At least in the old code. I see that snmpd added br_offs > in a way that causes this breakage.

Re: call ber_read() from ber_getc() in ldap, ldapd, and ypldap

2018-07-03 Thread Claudio Jeker
On Tue, Jul 03, 2018 at 03:45:49PM -0400, Rob Pierce wrote: > On Sat, Jun 30, 2018 at 02:04:16PM -0400, Rob Pierce wrote: > > I recently committed a piece of BER code synchronizing in the wrong > > direction > > (i.e. from the ldap instances to the snmpd instance). sthen@ noticed a break > > in

Re: call ber_read() from ber_getc() in ldap, ldapd, and ypldap

2018-07-03 Thread Rob Pierce
On Sat, Jun 30, 2018 at 02:04:16PM -0400, Rob Pierce wrote: > I recently committed a piece of BER code synchronizing in the wrong direction > (i.e. from the ldap instances to the snmpd instance). sthen@ noticed a break > in SNMPv3 authentication and reverted that part of the change. Thanks Stuart!