Re: httpd(8): don't try to chunk-encode an empty body

2021-05-18 Thread Florian Obser
On 2021-05-18 00:47 +02, Sebastian Benoit wrote: > The comments in server_fcgi_header seem to suggest more dragons lurk in this > area. Sush! -- I'm not entirely sure you are real.

Re: httpd(8): don't try to chunk-encode an empty body

2021-05-17 Thread Sebastian Benoit
Florian Obser(flor...@openbsd.org) on 2021.05.15 17:14:38 +0200: > Turns out it's not that difficult to do this correctly since we already > wait until we read all http headers from the fcgi upstream. We just need > to delay writing of the http header until we know if the body is empty > or not. >

Re: httpd(8): don't try to chunk-encode an empty body

2021-05-15 Thread Steve Williams
Hi, I can confirm this patch (from the 6.9 source) makes httpd work with Android Nextcloud client 3.16, where the unpatched httpd does not work. Thanks very much! Cheers, Steve Williams On 15/05/2021 9:14 a.m., Florian Obser wrote: Turns out it's not that difficult to do this correctly

Re: httpd(8): don't try to chunk-encode an empty body

2021-05-15 Thread Florian Obser
Turns out it's not that difficult to do this correctly since we already wait until we read all http headers from the fcgi upstream. We just need to delay writing of the http header until we know if the body is empty or not. OK? diff --git httpd.h httpd.h index b3a40b3af68..c4adfba232d 100644

Re: httpd(8): don't try to chunk-encode an empty body

2021-05-14 Thread Sebastian Benoit
Florian Obser(flor...@openbsd.org) on 2021.05.14 19:13:49 +0200: > As found out by Chris Narkiewicz the hard way, trying to chunk encode an > empty body makes the nextclown app stop working. (see "Nextcloud stopped > working after upgrade to 6.9" on ports@). > > I don't think there is a valid way