Re: installer: zap fdisk.8.gz and disklabel.8.gz

2022-08-25 Thread Theo de Raadt
Klemens Nanni wrote: > On Thu, Aug 25, 2022 at 07:07:27PM +, Miod Vallat wrote: > > > Well, something tells me the inclusion of the manual pages for fdisk > > > and disklabel is deliberate. Makes some sense as these are complex > > > utilities and their interactive use is documented in

Re: installer: zap fdisk.8.gz and disklabel.8.gz

2022-08-25 Thread Theo de Raadt
Wow you have it so backwards. So we will have embedded manuals for the case we don't need need the embedded manual because you have manuals installed (type ^Z and run man) but in the systems where you don't have manual pages, you won't have the embedded manuals. Very logical to forget why this

Re: installer: zap fdisk.8.gz and disklabel.8.gz

2022-08-25 Thread Theo de Raadt
I think you have this wrong. If someone is operating in the install media, and manually adjusting their disk, and they don't know the commands they need, where are they going to find the instructions? In 1997, we added the embedded manual pages to fdisk (inside the 'manual' command) and

Re: installer: zap fdisk.8.gz and disklabel.8.gz

2022-08-25 Thread Otto Moerbeek
On Thu, Aug 25, 2022 at 07:32:16PM +, Miod Vallat wrote: > > > The ability to be able to read the manual pages from the binaries > > > themselves, when running is interactive mode, is an intentional feature > > > and the reason they embed a gzipped version of the formatted manpage. > > > >

Re: installer: zap fdisk.8.gz and disklabel.8.gz

2022-08-25 Thread Miod Vallat
> > The ability to be able to read the manual pages from the binaries > > themselves, when running is interactive mode, is an intentional feature > > and the reason they embed a gzipped version of the formatted manpage. > > Even in the installer? Especially in the installer, because you might

Re: installer: zap fdisk.8.gz and disklabel.8.gz

2022-08-25 Thread Klemens Nanni
On Thu, Aug 25, 2022 at 07:07:27PM +, Miod Vallat wrote: > > Well, something tells me the inclusion of the manual pages for fdisk > > and disklabel is deliberate. Makes some sense as these are complex > > utilities and their interactive use is documented in those pages. > > The ability to be

Re: installer: zap fdisk.8.gz and disklabel.8.gz

2022-08-25 Thread Miod Vallat
> Well, something tells me the inclusion of the manual pages for fdisk > and disklabel is deliberate. Makes some sense as these are complex > utilities and their interactive use is documented in those pages. The ability to be able to read the manual pages from the binaries themselves, when

Re: installer: zap fdisk.8.gz and disklabel.8.gz

2022-08-25 Thread Mark Kettenis
> Date: Thu, 25 Aug 2022 18:58:39 + > From: Klemens Nanni > > On Thu, Aug 25, 2022 at 06:36:55PM +, Klemens Nanni wrote: > > Turns out all install media ship full copies of those two manuals due to > > what can be described like a makefile TOCTOU. > > > > In /usr/src/distrib/special,

Re: installer: zap fdisk.8.gz and disklabel.8.gz

2022-08-25 Thread Klemens Nanni
On Thu, Aug 25, 2022 at 06:36:55PM +, Klemens Nanni wrote: > Turns out all install media ship full copies of those two manuals due to > what can be described like a makefile TOCTOU. > > In /usr/src/distrib/special, Makefile.inc sets NOMAN=1 but */Makefile > only includes it in the very end