Re: ksh: [vi.c] "clear-screen" bug + patch

2021-03-10 Thread Theo Buehler
On Wed, Mar 10, 2021 at 01:10:55PM -0700, Todd C. Miller wrote: > Now the the clear screen change has been committed, here's the > insert mode ^R (redraw) diff again with a man page update. Note > that ^R is already supported in command mode. > ok

Re: ksh: [vi.c] "clear-screen" bug + patch

2021-03-10 Thread Todd C . Miller
Now the the clear screen change has been committed, here's the insert mode ^R (redraw) diff again with a man page update. Note that ^R is already supported in command mode. OK? - todd Index: bin/ksh/ksh.1 === RCS file:

Re: ksh: [vi.c] "clear-screen" bug + patch

2021-03-10 Thread Theo Buehler
On Tue, Mar 09, 2021 at 10:03:56AM -0700, Todd C. Miller wrote: > I think that in do_clear_screen() full should not be set unless > neednl is 0. That is, we should only print the entire prompt if > the screen was actually cleared. Otherwise looks good to me. ok tb

Re: ksh: [vi.c] "clear-screen" bug + patch

2021-03-09 Thread Todd C . Miller
On Tue, 09 Mar 2021 17:53:06 +0100, Benjamin Baier wrote: > Ping I think that in do_clear_screen() full should not be set unless neednl is 0. That is, we should only print the entire prompt if the screen was actually cleared. Otherwise looks good to me. - todd Index: bin/ksh/vi.c

Re: ksh: [vi.c] "clear-screen" bug + patch

2021-03-09 Thread Benjamin Baier
Ping On Sat, 21 Nov 2020 18:59:25 +0200 Πάτερος Πέτρος wrote: > Hello everyone, > > I am sending this because of an issue I had with a ported version of > your ksh(1) on Linux (you can find the port at > https://github.com/ibara/oksh), but everything I say here are also > tested on a VM