On Tue, Jun 22, 2021 at 01:29:59PM +, Klemens Nanni wrote:
> On Tue, Jun 22, 2021 at 06:35:44AM +0100, Jason McIntyre wrote:
> > > -sets the files from which the public certificate, and private key will
> > > be read.
> > > +loads two files from which the public certificate, and private key
On Tue, Jun 22, 2021 at 06:35:44AM +0100, Jason McIntyre wrote:
> > -sets the files from which the public certificate, and private key will be
> > read.
> > +loads two files from which the public certificate, and private key will be
> > read.
>
> this is a weird place for a comma. i would
On Tue, Jun 22, 2021 at 04:48:39AM +0200, Theo Buehler wrote:
> >
> > Feedback? OK?
>
> You have two overlong lines as indicated below. I would have thought
> that mandoc -Tlint complains about that, but apparently it doesn't have
> such a warning... With those wrapped,
>
yes, there is no
On Mon, Jun 21, 2021 at 11:26:41PM +, Klemens Nanni wrote:
>
> Thanks. tls_config_add_*_file also load files into memory, but given
> this patch I think their usage of "add" in the manual is enough to infer
> that files will also be loaded and added, so no need to change those as
> well, I
On Mon, Jun 21, 2021 at 11:26:41PM +, Klemens Nanni wrote:
> On Sun, Jun 20, 2021 at 09:32:36PM +0200, Theo Buehler wrote:
> > On Sat, Jun 19, 2021 at 03:34:39PM +, Klemens Nanni wrote:
> > > On Thu, Jun 10, 2021 at 10:26:15PM +, Klemens Nanni wrote:
> > > > tls_config_set_ca_file(3)
On Sun, Jun 20, 2021 at 09:32:36PM +0200, Theo Buehler wrote:
> On Sat, Jun 19, 2021 at 03:34:39PM +, Klemens Nanni wrote:
> > On Thu, Jun 10, 2021 at 10:26:15PM +, Klemens Nanni wrote:
> > > tls_config_set_ca_file(3) and tls_config_set_cert_file(3) do not just
> > > set the file paths
On Sat, Jun 19, 2021 at 03:34:39PM +, Klemens Nanni wrote:
> On Thu, Jun 10, 2021 at 10:26:15PM +, Klemens Nanni wrote:
> > tls_config_set_ca_file(3) and tls_config_set_cert_file(3) do not just
> > set the file paths (like tls_config_set_ca_path(3) does), they do load
> > the given file
On Thu, Jun 10, 2021 at 10:26:15PM +, Klemens Nanni wrote:
> tls_config_set_ca_file(3) and tls_config_set_cert_file(3) do not just
> set the file paths (like tls_config_set_ca_path(3) does), they do load
> the given file into memory directly using tls_config_load_file().
>
> This distinction
