Re: Rename ps_flags -> ps_sigflags in struct sigacts

2020-03-12 Thread Amit Kulkarni
> > > > I have the same issue with ps_flags vs ps_flags and I think it resulted in > > some major confusion for others as well. See inline. > > I agree this would make grep/looking at code easier :o) > > > > @@ -336,9 +336,9 @@ setsigvec(struct proc *p, int signum, st > > > ps->ps_catchmask[si

Re: Rename ps_flags -> ps_sigflags in struct sigacts

2020-03-12 Thread Martin Pieuchot
On 12/03/20(Thu) 14:30, Claudio Jeker wrote: > On Thu, Mar 12, 2020 at 08:15:00AM -0500, Amit Kulkarni wrote: > > Hi, > > > > In grepping for ps_flags in /sys, it is confusing to see that ps_flags is > > associated with > > > > 1) PWM_POLARITY (power regulation?). > > Proposed to rename to p

Re: Rename ps_flags -> ps_sigflags in struct sigacts

2020-03-12 Thread Claudio Jeker
On Thu, Mar 12, 2020 at 08:15:00AM -0500, Amit Kulkarni wrote: > Hi, > > In grepping for ps_flags in /sys, it is confusing to see that ps_flags is > associated with > > 1) PWM_POLARITY (power regulation?). > Proposed to rename to ps_pwmflags? > 2) process signals: struct sigacts in /sys/sy

Rename ps_flags -> ps_sigflags in struct sigacts

2020-03-12 Thread Amit Kulkarni
Hi, In grepping for ps_flags in /sys, it is confusing to see that ps_flags is associated with 1) PWM_POLARITY (power regulation?). Proposed to rename to ps_pwmflags? 2) process signals: struct sigacts in /sys/sys/signalvar.h 3) its rightful usage as ps_flags for struct process in /sys/sy