Re: Small patch for fmt(1)

2013-11-19 Thread drosih
On Mon, 18 Nov 2013 22:16:54 EST Eitan Adler wrote: Hi all, clang gives a warning when building fmt(1): fmt.c:400:35: warning: passing 'char *' to parameter of type 'const unsigned char *' converts between pointers to integer types with different sign might_be_header

Small patch for fmt(1)

2013-11-18 Thread Eitan Adler
Hi all, clang gives a warning when building fmt(1): fmt.c:400:35: warning: passing 'char *' to parameter of type 'const unsigned char *' converts between pointers to integer types with different sign might_be_header takes a pointer to unsigned char. However there is no reason for this to be

Re: Small patch for fmt(1)

2013-11-18 Thread Philip Guenther
On Mon, Nov 18, 2013 at 7:16 PM, Eitan Adler li...@eitanadler.com wrote: clang gives a warning when building fmt(1): fmt.c:400:35: warning: passing 'char *' to parameter of type 'const unsigned char *' converts between pointers to integer types with different sign might_be_header takes a

Re: Small patch for fmt(1)

2013-11-18 Thread Eitan Adler
On Mon, Nov 18, 2013 at 11:09 PM, Philip Guenther guent...@gmail.com wrote: On Mon, Nov 18, 2013 at 7:16 PM, Eitan Adler li...@eitanadler.com wrote: The argument passed to isupper must be The argument to isupper() must be EOF or representable as an unsigned char; otherwise, the result is