Re: Use after free in X config parser

2023-10-14 Thread Crystal Kolipe
On Sat, Oct 14, 2023 at 07:14:29PM +0200, Matthieu Herrb wrote: > On Sun, Oct 08, 2023 at 02:50:10PM -0300, Crystal Kolipe wrote: > > Hi, > > > > On Sun, Oct 08, 2023 at 07:07:27PM +0200, Matthieu Herrb wrote: > > > I can confirm that there's an issue here. However in my tests, I don't > > > see

Re: Use after free in X config parser

2023-10-14 Thread Matthieu Herrb
On Sun, Oct 08, 2023 at 02:50:10PM -0300, Crystal Kolipe wrote: > Hi, > > On Sun, Oct 08, 2023 at 07:07:27PM +0200, Matthieu Herrb wrote: > > I can confirm that there's an issue here. However in my tests, I don't > > see a garbled error message. > > If I set MALLOC_OPTIONS=F then a double free is

Re: Use after free in X config parser

2023-10-08 Thread Crystal Kolipe
Hi, On Sun, Oct 08, 2023 at 07:07:27PM +0200, Matthieu Herrb wrote: > I can confirm that there's an issue here. However in my tests, I don't > see a garbled error message. > If I set MALLOC_OPTIONS=F then a double free is reported, which I > tracked down to the realloc() calls in getNextLine()

Re: Use after free in X config parser

2023-10-08 Thread Matthieu Herrb
On Thu, Oct 05, 2023 at 08:11:39PM -0300, Crystal Kolipe wrote: > This is an interesting one... > > There is a use after free bug in the X config parser, which can be trivially > demonstrated by creating a config file with the first line being a comment and > the second line containing invalid

Use after free in X config parser

2023-10-05 Thread Crystal Kolipe
This is an interesting one... There is a use after free bug in the X config parser, which can be trivially demonstrated by creating a config file with the first line being a comment and the second line containing invalid syntax: $ echo "#foo\nfoo" > custom_config $ X -config custom_config [...]