Re: add sendmmsg and recvmmsg systemcalls

2022-09-08 Thread Alexander Bluhm
On Thu, Sep 08, 2022 at 03:01:14PM +0200, Moritz Buhl wrote: > On Wed, Aug 31, 2022 at 05:44:31PM -0900, Philip Guenther wrote: > > kdump.c will need at least a SYS_recvmmsg line in the big table, and if you > > do a ktrmmsghdr() bit in the kernel a matching decoder will be needed in > > kdump. >

Re: add sendmmsg and recvmmsg systemcalls

2022-09-08 Thread Moritz Buhl
On Wed, Aug 31, 2022 at 05:44:31PM -0900, Philip Guenther wrote: > kdump.c will need at least a SYS_recvmmsg line in the big table, and if you > do a ktrmmsghdr() bit in the kernel a matching decoder will be needed in > kdump. Here is a new diff for kdump. OK? mbuhl Index: usr.bin/kdump/kdump.c

Re: add sendmmsg and recvmmsg systemcalls

2022-09-06 Thread Moritz Buhl
On Tue, Sep 06, 2022 at 04:00:39PM +0200, Moritz Buhl wrote: > Hi, > here is the most recent diff for the libc part of send and recvmmsg. > This requires a libc minor bump and therefore should be coordinated > after snapshots are building normally again. > > To my understanding the minor bump

Re: add sendmmsg and recvmmsg systemcalls

2022-09-06 Thread Moritz Buhl
Hi, here is the most recent diff for the libc part of send and recvmmsg. This requires a libc minor bump and therefore should be coordinated after snapshots are building normally again. To my understanding the minor bump itself should not cause problems in ports anymore. mbuhl Index:

Re: add sendmmsg and recvmmsg systemcalls

2022-09-03 Thread Alexander Bluhm
On Sat, Sep 03, 2022 at 01:49:27AM +0200, Moritz Buhl wrote: > Here is an updated version of the kernel part for sendmmsg. OK bluhm@ > Index: sys/kern/syscalls.master > === > RCS file:

Re: add sendmmsg and recvmmsg systemcalls

2022-09-02 Thread Moritz Buhl
Here is an updated version of the kernel part for sendmmsg. mbuhl Index: sys/kern/syscalls.master === RCS file: /mount/openbsd/cvs/src/sys/kern/syscalls.master,v retrieving revision 1.230 diff -u -p -r1.230 syscalls.master ---

Re: add sendmmsg and recvmmsg systemcalls

2022-09-02 Thread Alexander Bluhm
On Thu, Sep 01, 2022 at 06:06:10PM +0200, Moritz Buhl wrote: > I addressed your concerns as well as these of jca, just the kernel > part (and the new ktrace stuff) below. > > One minor thing: I didn't see any kdump output where one struct was > contained in another one but I am printing it like

Re: add sendmmsg and recvmmsg systemcalls

2022-09-01 Thread Moritz Buhl
I addressed your concerns as well as these of jca, just the kernel part (and the new ktrace stuff) below. One minor thing: I didn't see any kdump output where one struct was contained in another one but I am printing it like ddb would so I guess it should be fine. Index: kern/syscalls.master

Re: add sendmmsg and recvmmsg systemcalls

2022-08-31 Thread Philip Guenther
On Tue, Aug 30, 2022 at 11:18 AM Moritz Buhl wrote: > the following diff only contains recvmmsg which should be the more useful > syscall of the two. > Comments inline. > --- sys/kern/syscalls.master1 Aug 2022 14:56:59 - 1.229 > +++ sys/kern/syscalls.master30 Aug 2022

Re: add sendmmsg and recvmmsg systemcalls

2022-08-31 Thread Jeremie Courreges-Anglas
On Tue, Aug 30 2022, Moritz Buhl wrote: > Hi tech@, > > the following diff only contains recvmmsg which should be the more useful > syscall of the two. > > I implemented some minor feedback regarding the man page and attaching > an error from recvit to the socket in case some messages were >

Re: add sendmmsg and recvmmsg systemcalls

2022-08-31 Thread Moritz Buhl
I created a pull request on their github: https://github.com/NLnetLabs/nsd/pull/231 On Tue, Aug 30, 2022 at 04:33:10PM -0600, Todd C. Miller wrote: > On Wed, 31 Aug 2022 00:19:20 +0200, Moritz Buhl wrote: > > > On Tue, Aug 30, 2022 at 10:59:43PM +0200, Claudio Jeker wrote: > > > And nsd in base.

Re: add sendmmsg and recvmmsg systemcalls

2022-08-30 Thread Todd C . Miller
On Wed, 31 Aug 2022 00:19:20 +0200, Moritz Buhl wrote: > On Tue, Aug 30, 2022 at 10:59:43PM +0200, Claudio Jeker wrote: > > And nsd in base. It seems unbound does not use recvmmsg. > > After 'make -f Makefile.bsd-wrapper config' recvmmsg is picked up. > The config compile test currently defines

Re: add sendmmsg and recvmmsg systemcalls

2022-08-30 Thread Moritz Buhl
On Tue, Aug 30, 2022 at 10:59:43PM +0200, Claudio Jeker wrote: > And nsd in base. It seems unbound does not use recvmmsg. After 'make -f Makefile.bsd-wrapper config' recvmmsg is picked up. The config compile test currently defines NONBLOCKING_IS_BROKEN because of a missing include. Then vlen

Re: add sendmmsg and recvmmsg systemcalls

2022-08-30 Thread Claudio Jeker
On Tue, Aug 30, 2022 at 09:51:46PM +0100, Stuart Henderson wrote: > btw a few ports will likely pick this up: > > paths/devel/glib2.log:Checking for function "recvmmsg" : NO > paths/net/tinc.log:checking for recvmmsg... no > paths/net/knot.log:checking for recvmmsg... no > paths/net/knot.log:

Re: add sendmmsg and recvmmsg systemcalls

2022-08-30 Thread Stuart Henderson
btw a few ports will likely pick this up: paths/devel/glib2.log:Checking for function "recvmmsg" : NO paths/net/tinc.log:checking for recvmmsg... no paths/net/knot.log:checking for recvmmsg... no paths/net/knot.log:Use recvmmsg: no paths/net/gdnsd.log:checking whether recvmmsg is

Re: add sendmmsg and recvmmsg systemcalls

2022-08-30 Thread Moritz Buhl
Hi tech@, the following diff only contains recvmmsg which should be the more useful syscall of the two. I implemented some minor feedback regarding the man page and attaching an error from recvit to the socket in case some messages were received before. I am also looking into passing the

add sendmmsg and recvmmsg systemcalls

2022-04-22 Thread Moritz Buhl
Hi tech@, I implemented the sendmmsg and recvmmsg system calls by copying the NetBSD implementation and adjusting it. The idea behind the mmsg system calls is to do less systemcalls per msghdr and thus improving throughput. This should allow faster processing of packages (UDP, raw IP) in