Re: adding a mutex to pf_state

2022-11-10 Thread David Gwynne
Yes please. ok dlg@. > On 10 Nov 2022, at 10:10 pm, Alexandr Nedvedicky wrote: > > Hello, > > David (dlg@) asked me to shrink the scope of the change. The new diff > introduces a mutex to pf_state and adjust pf_detach_state() to utilize the > newly introduced mutex. I've also added

Re: adding a mutex to pf_state

2022-11-10 Thread Alexandr Nedvedicky
Hello, David (dlg@) asked me to shrink the scope of the change. The new diff introduces a mutex to pf_state and adjust pf_detach_state() to utilize the newly introduced mutex. I've also added annotation to pf_state members. The members with '?' needs our attention. We need to verify if they are

adding a mutex to pf_state

2022-11-09 Thread Alexandr Nedvedicky
hello, diff below adds a mutex to pf_state. It fixes a NULL pointer dereference panic reported by Hrvoje sometime ago [1]. Besides adding a mutex to state the diff addresses a race between pfsync and state purge thread. What happened in this particular case was that state expired and its state