Re: arpresolve reduce kernel lock

2023-04-26 Thread Vitaliy Makkoveev
> On 26 Apr 2023, at 15:30, Hrvoje Popovski wrote: > > On 26.4.2023. 12:15, Alexander Bluhm wrote: >> On Wed, Apr 26, 2023 at 11:17:32AM +0200, Alexander Bluhm wrote: >>> On Tue, Apr 25, 2023 at 11:57:09PM +0300, Vitaliy Makkoveev wrote: On Tue, Apr 25, 2023 at 11:44:34AM +0200, Alexander

Re: arpresolve reduce kernel lock

2023-04-26 Thread Hrvoje Popovski
On 26.4.2023. 12:15, Alexander Bluhm wrote: > On Wed, Apr 26, 2023 at 11:17:32AM +0200, Alexander Bluhm wrote: >> On Tue, Apr 25, 2023 at 11:57:09PM +0300, Vitaliy Makkoveev wrote: >>> On Tue, Apr 25, 2023 at 11:44:34AM +0200, Alexander Bluhm wrote: Hi, Mutex arp_mtx protects the

Re: arpresolve reduce kernel lock

2023-04-26 Thread Alexander Bluhm
On Wed, Apr 26, 2023 at 11:17:32AM +0200, Alexander Bluhm wrote: > On Tue, Apr 25, 2023 at 11:57:09PM +0300, Vitaliy Makkoveev wrote: > > On Tue, Apr 25, 2023 at 11:44:34AM +0200, Alexander Bluhm wrote: > > > Hi, > > > > > > Mutex arp_mtx protects the llinfo_arp la_... fields. So kernel > > >

Re: arpresolve reduce kernel lock

2023-04-26 Thread Alexander Bluhm
On Tue, Apr 25, 2023 at 11:57:09PM +0300, Vitaliy Makkoveev wrote: > On Tue, Apr 25, 2023 at 11:44:34AM +0200, Alexander Bluhm wrote: > > Hi, > > > > Mutex arp_mtx protects the llinfo_arp la_... fields. So kernel > > lock is only needed for changing the route rt_flags. > > > > Of course there

Re: arpresolve reduce kernel lock

2023-04-26 Thread Hrvoje Popovski
On 25.4.2023. 22:57, Vitaliy Makkoveev wrote: > On Tue, Apr 25, 2023 at 11:44:34AM +0200, Alexander Bluhm wrote: >> Hi, >> >> Mutex arp_mtx protects the llinfo_arp la_... fields. So kernel >> lock is only needed for changing the route rt_flags. >> >> Of course there is a race between checking

Re: arpresolve reduce kernel lock

2023-04-25 Thread Vitaliy Makkoveev
On Tue, Apr 25, 2023 at 11:44:34AM +0200, Alexander Bluhm wrote: > Hi, > > Mutex arp_mtx protects the llinfo_arp la_... fields. So kernel > lock is only needed for changing the route rt_flags. > > Of course there is a race between checking and setting rt_flags. > But the other checks of the

Re: arpresolve reduce kernel lock

2023-04-25 Thread Klemens Nanni
On Tue, Apr 25, 2023 at 04:15:49PM +, Klemens Nanni wrote: > A clearer version of this diff would use two new bools `expired' and `reject' > rather than a ternary `reject', but that can be polished and retested later. Or simpler even, use new `expired' and existing `refresh'. Refresh and

Re: arpresolve reduce kernel lock

2023-04-25 Thread Klemens Nanni
On Tue, Apr 25, 2023 at 11:44:34AM +0200, Alexander Bluhm wrote: > Hi, > > Mutex arp_mtx protects the llinfo_arp la_... fields. So kernel > lock is only needed for changing the route rt_flags. > > Of course there is a race between checking and setting rt_flags. > But the other checks of the

arpresolve reduce kernel lock

2023-04-25 Thread Alexander Bluhm
Hi, Mutex arp_mtx protects the llinfo_arp la_... fields. So kernel lock is only needed for changing the route rt_flags. Of course there is a race between checking and setting rt_flags. But the other checks of the RTF_REJECT flags were without kernel lock before. This does not cause trouble,