Re: bgpd: add format attributes

2016-06-06 Thread Claudio Jeker
On Sat, Jun 04, 2016 at 06:33:57PM +0200, Sebastian Benoit wrote: > Add format attributes to the proper functions and then fix the warning in > session.c. > > ok? OK claudio Make sure that bgpctl still compiles in all its version (bgplg) > diff --git bgpd.h bgpd.h > index 5fa046e..eaf93e6 1006

Re: bgpd: add format attributes

2016-06-05 Thread Martin Pieuchot
On 05/06/16(Sun) 20:33, Sebastian Benoit wrote: > Martin Pieuchot(m...@openbsd.org) on 2016.06.05 20:06:17 +0200: > > On 04/06/16(Sat) 18:33, Sebastian Benoit wrote: > > > Add format attributes to the proper functions and then fix the warning in > > > session.c. > > > > Shouldn't you introduce a l

Re: bgpd: add format attributes

2016-06-05 Thread Sebastian Benoit
Martin Pieuchot(m...@openbsd.org) on 2016.06.05 20:06:17 +0200: > On 04/06/16(Sat) 18:33, Sebastian Benoit wrote: > > Add format attributes to the proper functions and then fix the warning in > > session.c. > > Shouldn't you introduce a log.h instead an make sure all daemons share > the same log.h

Re: bgpd: add format attributes

2016-06-05 Thread Martin Pieuchot
On 04/06/16(Sat) 18:33, Sebastian Benoit wrote: > Add format attributes to the proper functions and then fix the warning in > session.c. Shouldn't you introduce a log.h instead an make sure all daemons share the same log.h and log.c? > diff --git bgpd.h bgpd.h > index 5fa046e..eaf93e6 100644 > --

bgpd: add format attributes

2016-06-04 Thread Sebastian Benoit
Add format attributes to the proper functions and then fix the warning in session.c. ok? diff --git bgpd.h bgpd.h index 5fa046e..eaf93e6 100644 --- bgpd.h +++ bgpd.h @@ -989,15 +989,24 @@ struct in6_addr *prefixlen2mask6(u_int8_t prefixlen); /* log.c */ voidlog_init(int); void