Re: bgpd: unbreak route origin validation

2019-03-31 Thread Denis Fondras
On Sun, Mar 31, 2019 at 06:03:01PM +0200, Claudio Jeker wrote: > On Fri, Mar 22, 2019 at 09:25:32PM +0100, Denis Fondras wrote: > > (better when the right diff is sent...) > > > > ROV has been broken since the configuration reload changes. > > > > Index: rde.c > >

Re: bgpd: unbreak route origin validation

2019-03-31 Thread Claudio Jeker
On Fri, Mar 22, 2019 at 09:25:32PM +0100, Denis Fondras wrote: > (better when the right diff is sent...) > > ROV has been broken since the configuration reload changes. > > Index: rde.c > === > RCS file:

Re: bgpd: unbreak route origin validation

2019-03-31 Thread Claudio Jeker
On Fri, Mar 22, 2019 at 04:47:46PM +0100, Denis Fondras wrote: > ROV has been broken since the configuration reload changes. I don't like this. The goal is to not use memcpy for struct bgpd_config because of all the pointer it holds. It feels like a field is missing in copy_config(). Will look

Re: bgpd: unbreak route origin validation

2019-03-23 Thread Sebastian Benoit
Denis Fondras(de...@openbsd.org) on 2019.03.22 21:25:32 +0100: > (better when the right diff is sent...) > > ROV has been broken since the configuration reload changes. ok > Index: rde.c > === > RCS file:

bgpd: unbreak route origin validation

2019-03-22 Thread Denis Fondras
(better when the right diff is sent...) ROV has been broken since the configuration reload changes. Index: rde.c === RCS file: /cvs/src/usr.sbin/bgpd/rde.c,v retrieving revision 1.466 diff -u -p -r1.466 rde.c --- rde.c 13 Mar

bgpd: unbreak route origin validation

2019-03-22 Thread Denis Fondras
ROV has been broken since the configuration reload changes. Index: rde.c === RCS file: /cvs/src/usr.sbin/bgpd/rde.c,v retrieving revision 1.466 diff -u -p -r1.466 rde.c --- rde.c 13 Mar 2019 14:35:39 - 1.466 +++ rde.c