Re: bgpd refactor aspath_match a bit

2018-12-10 Thread Denis Fondras
On Thu, Dec 06, 2018 at 12:21:19PM +0100, Claudio Jeker wrote: > On Wed, Nov 28, 2018 at 10:35:37AM +0100, Claudio Jeker wrote: > > On Tue, Nov 27, 2018 at 06:55:51PM +0100, Job Snijders wrote: > > > On Tue, Nov 27, 2018 at 06:23:53PM +0100, Claudio Jeker wrote: > > > > On Tue, Nov 27, 2018 at

Re: bgpd refactor aspath_match a bit

2018-12-06 Thread Claudio Jeker
On Wed, Nov 28, 2018 at 10:35:37AM +0100, Claudio Jeker wrote: > On Tue, Nov 27, 2018 at 06:55:51PM +0100, Job Snijders wrote: > > On Tue, Nov 27, 2018 at 06:23:53PM +0100, Claudio Jeker wrote: > > > On Tue, Nov 27, 2018 at 04:21:53PM +0100, Job Snijders wrote: > > > > On Fri, Nov 23, 2018 at

Re: bgpd refactor aspath_match a bit

2018-11-28 Thread Claudio Jeker
On Tue, Nov 27, 2018 at 06:55:51PM +0100, Job Snijders wrote: > On Tue, Nov 27, 2018 at 06:23:53PM +0100, Claudio Jeker wrote: > > On Tue, Nov 27, 2018 at 04:21:53PM +0100, Job Snijders wrote: > > > On Fri, Nov 23, 2018 at 03:55:18PM +0100, Claudio Jeker wrote: > > > > For origin validation I

Re: bgpd refactor aspath_match a bit

2018-11-27 Thread Job Snijders
On Tue, Nov 27, 2018 at 06:23:53PM +0100, Claudio Jeker wrote: > On Tue, Nov 27, 2018 at 04:21:53PM +0100, Job Snijders wrote: > > On Fri, Nov 23, 2018 at 03:55:18PM +0100, Claudio Jeker wrote: > > > For origin validation I chacked the source_as in struct rde_aspath > > > this is not really the

Re: bgpd refactor aspath_match a bit

2018-11-27 Thread Claudio Jeker
On Tue, Nov 27, 2018 at 04:21:53PM +0100, Job Snijders wrote: > Hi Claudio, > > On Fri, Nov 23, 2018 at 03:55:18PM +0100, Claudio Jeker wrote: > > For origin validation I chacked the source_as in struct rde_aspath > > this is not really the right place. It should be in struct aspath > > since

Re: bgpd refactor aspath_match a bit

2018-11-27 Thread Job Snijders
Hi Claudio, On Fri, Nov 23, 2018 at 03:55:18PM +0100, Claudio Jeker wrote: > For origin validation I chacked the source_as in struct rde_aspath > this is not really the right place. It should be in struct aspath > since that holds all the ASPATH related stuff. Change this, move > aspath_match out

bgpd refactor aspath_match a bit

2018-11-23 Thread Claudio Jeker
For origin validation I chacked the source_as in struct rde_aspath this is not really the right place. It should be in struct aspath since that holds all the ASPATH related stuff. Change this, move aspath_match out of util.c back into rde_attr.c and adjust code to use the cached value also in