Re: bin/ksh: fix possible use of uninitialized variable

2011-03-16 Thread Theo de Raadt
I don't see any warnings. Please show them. If gcc is being fooled by loops, then this is because gcc is stupid. it you show the warnings we can judge it. In particular, the slen one looks totally bogus. This diff fixes uninitialized variable warnings emitted by gcc 4.2.1 on i386/amd64.

Re: bin/ksh: fix possible use of uninitialized variable

2011-03-16 Thread Okan Demirmen
On Wed 2011.03.16 at 12:30 -0600, Theo de Raadt wrote: I don't see any warnings. Please show them. ksh builds with -Wall by default, so these were emitted: /home/okan/hack/open/ksh/ksh-current/eval.c: In function 'expand': /home/okan/hack/open/ksh/ksh-current/eval.c:155: warning: 'x.split' may

Re: bin/ksh: fix possible use of uninitialized variable

2011-03-14 Thread Okan Demirmen
On Mon 2011.03.14 at 11:05 +0800, Kevin Lo wrote: This diff fixes uninitialized variable warnings emitted by gcc 4.2.1 on i386/amd64. How's this instead (lifted from mksh)? Index: eval.c === RCS file:

bin/ksh: fix possible use of uninitialized variable

2011-03-13 Thread Kevin Lo
This diff fixes uninitialized variable warnings emitted by gcc 4.2.1 on i386/amd64. Index: eval.c === RCS file: /cvs/src/bin/ksh/eval.c,v retrieving revision 1.35 diff -u -p -r1.35 eval.c --- eval.c 24 Mar 2010 08:27:26 -