Re: connect_sync

2016-08-19 Thread Todd C. Miller
ude void abort_remote(FILE *); void abortpt(int); @@ -76,7 +75,7 @@ void cmdabort(int); void cmdscanner(int); intcommand(const char *, ...); intconfirm(const char *, const char *); -intconnect_sync(int, const struct sockaddr *, socklen_t); +intconnect_wait(int); FILE

Re: connect_sync

2016-08-19 Thread Ted Unangst
Todd C. Miller wrote: > Here's a rewrite of my connect_sync() changes to use connect_wait() > instead. Unlike the version in the connect(2) manual, this one > returns EINTR when interrupted by a signal which is probably better. > Index: usr.bin

Re: connect_sync

2016-08-19 Thread Todd C. Miller
Here's a rewrite of my connect_sync() changes to use connect_wait() instead. Unlike the version in the connect(2) manual, this one returns EINTR when interrupted by a signal which is probably better. - todd Index: usr.bin/ftp/extern.h

Re: connect_sync

2016-08-19 Thread Todd C. Miller
Another option is to use the connect_wait() function I added to EXAMPLES in connect(2). You would only call it if connect(2) returns -1 with errno == EINTR. - todd

connect_sync

2016-08-19 Thread Ted Unangst
connect_sync looks like it could be a useful piece of code in other places. however, putting the loop in the function means that ^C may not work... ftp has disgusting signal handlers and longjmps, but i don't think that's how we want other programs to be written. i've rewritten the function