Re: convert sppp(4) to taskq

2013-11-18 Thread David Gwynne
On 18 Nov 2013, at 11:59 pm, Martin Pieuchot wrote: > On 18/11/13(Mon) 13:35, Stefan Sperling wrote: >> On Mon, Nov 18, 2013 at 12:37:53PM +0100, Martin Pieuchot wrote: >>> Even if right now calling task_del() is enough, do you know if there's >>> an easy way to convert this code without putting

Re: convert sppp(4) to taskq

2013-11-18 Thread Martin Pieuchot
On 18/11/13(Mon) 13:35, Stefan Sperling wrote: > On Mon, Nov 18, 2013 at 12:37:53PM +0100, Martin Pieuchot wrote: > > Even if right now calling task_del() is enough, do you know if there's > > an easy way to convert this code without putting the task storage in > > the chunk of memory it manipulate

Re: convert sppp(4) to taskq

2013-11-18 Thread Stefan Sperling
On Mon, Nov 18, 2013 at 12:37:53PM +0100, Martin Pieuchot wrote: > Even if right now calling task_del() is enough, do you know if there's > an easy way to convert this code without putting the task storage in > the chunk of memory it manipulates? In other words having the "struct > task" outside o

Re: convert sppp(4) to taskq

2013-11-18 Thread Martin Pieuchot
On 15/11/13(Fri) 15:45, Stefan Sperling wrote: > On Fri, Nov 15, 2013 at 03:20:48PM +0100, Mike Belopuhov wrote: > > On 15 November 2013 15:13, Stefan Sperling wrote: > > > Is this done right? > > > > > > Works here with pppoe(4) for both IPv4 and IPv6. > > > > > > > i think this diff might lack

Re: convert sppp(4) to taskq

2013-11-15 Thread Mike Belopuhov
On 15 November 2013 15:45, Stefan Sperling wrote: > On Fri, Nov 15, 2013 at 03:20:48PM +0100, Mike Belopuhov wrote: >> On 15 November 2013 15:13, Stefan Sperling wrote: >> > Is this done right? >> > >> > Works here with pppoe(4) for both IPv4 and IPv6. >> > >> >> i think this diff might lack task

Re: convert sppp(4) to taskq

2013-11-15 Thread Stefan Sperling
On Fri, Nov 15, 2013 at 03:20:48PM +0100, Mike Belopuhov wrote: > On 15 November 2013 15:13, Stefan Sperling wrote: > > Is this done right? > > > > Works here with pppoe(4) for both IPv4 and IPv6. > > > > i think this diff might lack task_del's in the detach code. Ooops, good catch. > have you

Re: convert sppp(4) to taskq

2013-11-15 Thread Mike Belopuhov
On 15 November 2013 15:13, Stefan Sperling wrote: > Is this done right? > > Works here with pppoe(4) for both IPv4 and IPv6. > i think this diff might lack task_del's in the detach code. have you tried destroying your pppoe interface?

convert sppp(4) to taskq

2013-11-15 Thread Stefan Sperling
Is this done right? Works here with pppoe(4) for both IPv4 and IPv6. Index: if_sppp.h === RCS file: /cvs/src/sys/net/if_sppp.h,v retrieving revision 1.19 diff -u -p -r1.19 if_sppp.h --- if_sppp.h 14 Nov 2013 16:52:33 - 1.1