On Fri, Dec 30 2022, Miod Vallat wrote:
>> I'm not sure which way to go: either sprinkle some -fno-common between
>> crunchgen and distrib/special/Makefile.inc, or drop -dc on lld archs
>> only. What would you folks prefer?
>
> I'd rather have the same behaviour for all platforms, but I need to
On Sat, Dec 31 2022, Theo de Raadt wrote:
> It seems some changes are being pushed without actually testing
> on the non-clang architectures.
>
> Can this get backed out until the correct procedure is followed?
Well nothing has been committed regarding this crunchgen change.
I hope you're not
It seems some changes are being pushed without actually testing
on the non-clang architectures.
Can this get backed out until the correct procedure is followed?
But I think it is also important to realize that not every
new behaviour of clang is "systems ready". Some of what they
are pushing
> I'm not sure which way to go: either sprinkle some -fno-common between
> crunchgen and distrib/special/Makefile.inc, or drop -dc on lld archs
> only. What would you folks prefer?
I'd rather have the same behaviour for all platforms, but I need to test
a few more gcc platforms first.
On Fri, Dec 30 2022, Miod Vallat wrote:
> You need this extra chunk for your diff to work. With that, the built
> instbin binary appears to behave as expected on hppa.
Heh, nice, thank you.
I'm not sure which way to go: either sprinkle some -fno-common between
crunchgen and
You need this extra chunk for your diff to work. With that, the built
instbin binary appears to behave as expected on hppa.
Index: distrib/special/Makefile.inc
===
RCS file: /OpenBSD/src/distrib/special/Makefile.inc,v
retrieving
> IIUC this ld(1) behavior is somewhat similar to -fno-common for cc(1).
> base-clang already does -fno-common by default, base-gcc does not. The
> diff below replaces ld -dc by cc -fno-common, but TBF I'm not sure what
> we're trying to achieve (avoid?) here. A test (make build + release) on
>
At first it looked like a fluke when building a release. What's this
"ld -dc" command-line? Well -dc is short for --define-common, an option
that has been dropped by upstream llvm(lld).
IIUC this ld(1) behavior is somewhat similar to -fno-common for cc(1).
base-clang already does -fno-common
