Re: diff: get rid the "out of static map entries" problem

2011-04-19 Thread Anton Maksimenkov
2011/4/19 Ariane van der Steldt : > You now have feedback. People don't like your diff, told you why. You > now have options: > You didn't get negative feedback on the reserved entry. It works for > your map, maybe it'll also work for the kernel_map? Most comments here > are against the kentry map.

Re: diff: get rid the "out of static map entries" problem

2011-04-19 Thread Ariane van der Steldt
On Tue, Apr 19, 2011 at 11:26:16AM +0600, Anton Maksimenkov wrote: > 2011/4/19 Ariane van der Steldt : > > Your diff is reducable to: > > ?static struct vm_map_entry kentries[REALLY_BIG_NUMBER]; > > And then managing that memory using vmmap. > > Yes, more or less... But your example eats VA memory

Re: diff: get rid the "out of static map entries" problem

2011-04-18 Thread Anton Maksimenkov
2011/4/19 Ariane van der Steldt : > Your diff is reducable to: > static struct vm_map_entry kentries[REALLY_BIG_NUMBER]; > And then managing that memory using vmmap. Yes, more or less... But your example eats VA memory and physical pages immediately and forever, while my diff tried to eat it on d

Re: diff: get rid the "out of static map entries" problem

2011-04-18 Thread Ariane van der Steldt
On Mon, Apr 18, 2011 at 10:24:32AM +0600, Anton Maksimenkov wrote: > 2011/4/18 Ted Unangst : > > +if (uvm.numof_free_kentries < 1) /*check to be safe*/ > > +panic("uvm.numof_free_kentries[%d] < 1\n", > uvm.numof_free_kentries); > >>> This diff would take us back to the bad old days whe

Re: diff: get rid the "out of static map entries" problem

2011-04-17 Thread Anton Maksimenkov
2011/4/18 Ted Unangst : > +if (uvm.numof_free_kentries < 1) /*check to be safe*/ > +panic("uvm.numof_free_kentries[%d] < 1\n", uvm.numof_free_kentries); >>> This diff would take us back to the bad old days when running out of entries led >>> to a panic. >> Totally conversely. As It was

Re: diff: get rid the "out of static map entries" problem

2011-04-17 Thread Ted Unangst
On Sun, Apr 17, 2011 at 12:49 AM, Anton Maksimenkov wrote: +if (uvm.numof_free_kentries < 1) /*check to be safe*/ +panic("uvm.numof_free_kentries[%d] < 1\n", uvm.numof_free_kentries); >> This diff would take us back to the bad old days when running out of entries led >> to a panic.

Re: diff: get rid the "out of static map entries" problem

2011-04-16 Thread Anton Maksimenkov
2011/4/17 Ted Unangst : >> This kentry_map must be used only for kentries allocation. Since all > This really isn't that much different than the static entries we have > now. You are pre-reserving them. No. Now, we have to trust to kmthread to preallocate pages. It is not possible to predict when

Re: diff: get rid the "out of static map entries" problem

2011-04-16 Thread Ted Unangst
On Sat, Apr 16, 2011 at 2:49 PM, Anton Maksimenkov wrote: > So I decide to create another special map called "kentry_map". > This kentry_map must be used only for kentries allocation. Since all This really isn't that much different than the static entries we have now. You are pre-reserving them.