Re: don't remove known vmd vm's on failure

2023-01-26 Thread Mike Larkin
On Sun, Jan 15, 2023 at 09:08:29AM -0500, Dave Voutila wrote: > > Dave Voutila writes: > > > It turns out not only does vmd have numerous error paths for handling > > when something is amiss with a guest, most of the paths don't check if > > it's a known vm defined in vm.conf. > > > > As a

Re: don't remove known vmd vm's on failure

2023-01-22 Thread Bob Beck
Tried it out here with my gimpy little test setup and your suggested repro case. Seems to be more sane to me in this case, and looks like the right thing to do, So ok beck@ for what that’s worth. > On Jan 21, 2023, at 8:08 AM, Dave Voutila wrote: > > > *bump*... Anyone able to test or

Re: don't remove known vmd vm's on failure

2023-01-21 Thread Dave Voutila
*bump*... Anyone able to test or review? Other than bikeshedding some function naming, this isn't a dramatic change. Dave Voutila writes: > Dave Voutila writes: > >> It turns out not only does vmd have numerous error paths for handling >> when something is amiss with a guest, most of the

Re: don't remove known vmd vm's on failure

2023-01-15 Thread Dave Voutila
Dave Voutila writes: > It turns out not only does vmd have numerous error paths for handling > when something is amiss with a guest, most of the paths don't check if > it's a known vm defined in vm.conf. > > As a result, vmd often removes the vm from the SLIST of vm's meaning > one can't

don't remove known vmd vm's on failure

2023-01-14 Thread Dave Voutila
It turns out not only does vmd have numerous error paths for handling when something is amiss with a guest, most of the paths don't check if it's a known vm defined in vm.conf. As a result, vmd often removes the vm from the SLIST of vm's meaning one can't easily attempt to start it again or see