Re: efiboot serial console support

2017-06-01 Thread YASUOKA Masahiko
Yes, I think this is the proper fix. Please commit. ok yasuoka On Thu, 1 Jun 2017 10:41:57 +0200 Patrick Wildt wrote: > On Thu, Jun 01, 2017 at 10:27:28AM +0200, Stefan Sperling wrote: >> On Tue, May 30, 2017 at 02:31:48PM +0200, YASUOKA Masahiko wrote: >> > + status = EFI_CALL(BS->LocateHandl

Re: efiboot serial console support

2017-06-01 Thread Patrick Wildt
On Thu, Jun 01, 2017 at 10:27:28AM +0200, Stefan Sperling wrote: > On Tue, May 30, 2017 at 02:31:48PM +0200, YASUOKA Masahiko wrote: > > + status = EFI_CALL(BS->LocateHandle, ByProtocol, &serio_guid, 0, &sz, 0); > > + if (status == EFI_BUFFER_TOO_SMALL) { > > + handles = alloc(sz); >

Re: efiboot serial console support

2017-06-01 Thread Stefan Sperling
On Tue, May 30, 2017 at 02:31:48PM +0200, YASUOKA Masahiko wrote: > + status = EFI_CALL(BS->LocateHandle, ByProtocol, &serio_guid, 0, &sz, 0); > + if (status == EFI_BUFFER_TOO_SMALL) { > + handles = alloc(sz); > + status = EFI_CALL(BS->LocateHandle, ByProtocol, &seri

Re: efiboot serial console support

2017-05-30 Thread YASUOKA Masahiko
Thanks, Let me update the diff. On Tue, 30 May 2017 13:58:29 +0200 Patrick Wildt wrote: > On Tue, May 30, 2017 at 12:58:48PM +0200, YASUOKA Masahiko wrote: >> The following diff is to support serial console on efiboot. > > Nice. >> >> It uses ACPI UID to identify the port number (com0, com1 an

Re: efiboot serial console support

2017-05-30 Thread Patrick Wildt
On Tue, May 30, 2017 at 12:58:48PM +0200, YASUOKA Masahiko wrote: > Hi, > > The following diff is to support serial console on efiboot. Nice. > > It uses ACPI UID to identify the port number (com0, com1 and so on) of > probed serial interface. But I'm not sure wether com0-com3 are always > map

efiboot serial console support

2017-05-30 Thread YASUOKA Masahiko
Hi, The following diff is to support serial console on efiboot. It uses ACPI UID to identify the port number (com0, com1 and so on) of probed serial interface. But I'm not sure wether com0-com3 are always mapped UID 0-3 as expected. Though I think this is good enough. Comment? diff --git a/sy