Re: filesystem code integer and many inodes

2020-06-05 Thread Matthias Schmidt
Hi Otto, * Otto Moerbeek wrote: > > Did anyone look closer at this? > > Did anyone test? I compiled kernel + world with your diff in a VM and performed the following tests. * fdisk, disklablel, newfs of an external disk * disklabel, growfs, fsck on a partition on an external disk * fsirand on

Re: filesystem code integer and many inodes

2020-06-02 Thread Otto Moerbeek
On Fri, May 29, 2020 at 09:30:04AM +0200, Otto Moerbeek wrote: > On Thu, May 28, 2020 at 12:54:41PM -0600, Todd C. Miller wrote: > > > On Thu, 28 May 2020 20:53:07 +0200, Otto Moerbeek wrote: > > > > > Here's the separate diff for the prefcg loops. From FreeBSD. > > > > OK millert@ > > > > -

Re: filesystem code integer and many inodes

2020-05-29 Thread Otto Moerbeek
On Fri, May 29, 2020 at 09:30:04AM +0200, Otto Moerbeek wrote: > On Thu, May 28, 2020 at 12:54:41PM -0600, Todd C. Miller wrote: > > > On Thu, 28 May 2020 20:53:07 +0200, Otto Moerbeek wrote: > > > > > Here's the separate diff for the prefcg loops. From FreeBSD. > > > > OK millert@ > > > > -

Re: filesystem code integer and many inodes

2020-05-29 Thread Otto Moerbeek
On Thu, May 28, 2020 at 12:54:41PM -0600, Todd C. Miller wrote: > On Thu, 28 May 2020 20:53:07 +0200, Otto Moerbeek wrote: > > > Here's the separate diff for the prefcg loops. From FreeBSD. > > OK millert@ > > - todd > And here's the updated diff against -current. I removed a redundant cast

Re: filesystem code integer and many inodes

2020-05-28 Thread Todd C . Miller
On Thu, 28 May 2020 20:53:07 +0200, Otto Moerbeek wrote: > Here's the separate diff for the prefcg loops. From FreeBSD. OK millert@ - todd

Re: filesystem code integer and many inodes

2020-05-28 Thread Otto Moerbeek
On Tue, May 26, 2020 at 04:11:50PM +0200, Otto Moerbeek wrote: > On Tue, May 26, 2020 at 03:54:15PM +0200, Otto Moerbeek wrote: > > > On Tue, May 26, 2020 at 07:51:28AM -0600, Todd C. Miller wrote: > > > > > On Tue, 26 May 2020 12:07:21 +0200, Otto Moerbeek wrote: > > > > > > > Apart from the

Re: filesystem code integer and many inodes

2020-05-26 Thread Otto Moerbeek
On Tue, May 26, 2020 at 03:54:15PM +0200, Otto Moerbeek wrote: > On Tue, May 26, 2020 at 07:51:28AM -0600, Todd C. Miller wrote: > > > On Tue, 26 May 2020 12:07:21 +0200, Otto Moerbeek wrote: > > > > > Apart from the noting the strange Subject: I also like to mention one > > > change in the way

Re: filesystem code integer and many inodes

2020-05-26 Thread Otto Moerbeek
On Tue, May 26, 2020 at 07:51:28AM -0600, Todd C. Miller wrote: > On Tue, 26 May 2020 12:07:21 +0200, Otto Moerbeek wrote: > > > Apart from the noting the strange Subject: I also like to mention one > > change in the way cylinder groups are scanned. The current code scans > > forward and

Re: filesystem code integer and many inodes

2020-05-26 Thread Todd C . Miller
On Tue, 26 May 2020 12:07:21 +0200, Otto Moerbeek wrote: > Apart from the noting the strange Subject: I also like to mention one > change in the way cylinder groups are scanned. The current code scans > forward and backward, which causes an uneven distribution of full cgs > (the upper end of the

Re: filesystem code integer and many inodes

2020-05-26 Thread Otto Moerbeek
On Tue, May 26, 2020 at 11:58:39AM +0200, Otto Moerbeek wrote: > Hi, > > In theory ffs code support a maximum of UINT_MAX inodes, but in > practice, due to integer overflows in the current code, the limit is > INT_MAX inodes. > > This fixes that, and allows me to create and use filesystems with

filesystem code integer and many inodes

2020-05-26 Thread Otto Moerbeek
Hi, In theory ffs code support a maximum of UINT_MAX inodes, but in practice, due to integer overflows in the current code, the limit is INT_MAX inodes. This fixes that, and allows me to create and use filesystems with more than INT_MAX inodes. This is partly from FreeBSD code. Main change is