Re: fix possible NULL deref in sys/dev/usb/uhub.c

2011-09-29 Thread Alexander Hall
On 09/29/11 12:06, Stefan Sperling wrote: On Fri, Feb 18, 2011 at 03:44:55AM +, Jacob Meuser wrote: at line 190, if nports == 0, 'hub' will be NULL at line 334, and 'if (hub->ports)' will be a NULL dereference. found by Amit Kulkarni using clang. I OK'd this diff back in February, but it

Re: fix possible NULL deref in sys/dev/usb/uhub.c

2011-09-29 Thread Paul Irofti
On Thu, Sep 29, 2011 at 12:06:19PM +0200, Stefan Sperling wrote: > On Fri, Feb 18, 2011 at 03:44:55AM +, Jacob Meuser wrote: > > at line 190, if nports == 0, 'hub' will be NULL at line 334, and > > 'if (hub->ports)' will be a NULL dereference. > > > > found by Amit Kulkarni using clang. > > I

Re: fix possible NULL deref in sys/dev/usb/uhub.c

2011-09-29 Thread Stefan Sperling
On Fri, Feb 18, 2011 at 03:44:55AM +, Jacob Meuser wrote: > at line 190, if nports == 0, 'hub' will be NULL at line 334, and > 'if (hub->ports)' will be a NULL dereference. > > found by Amit Kulkarni using clang. I OK'd this diff back in February, but it seems this still hasn't been committed

Re: fix possible NULL deref in sys/dev/usb/uhub.c

2011-02-18 Thread Kenneth R Westerback
On Fri, Feb 18, 2011 at 12:27:40PM +0100, Mike Belopuhov wrote: > On Fri, Feb 18, 2011 at 03:44 +, Jacob Meuser wrote: > > at line 190, if nports == 0, 'hub' will be NULL at line 334, and > > 'if (hub->ports)' will be a NULL dereference. > > > > found by Amit Kulkarni using clang. > > > > ma

Re: fix possible NULL deref in sys/dev/usb/uhub.c

2011-02-18 Thread Paul Irofti
On Fri, Feb 18, 2011 at 03:44:55AM +, Jacob Meuser wrote: > at line 190, if nports == 0, 'hub' will be NULL at line 334, and > 'if (hub->ports)' will be a NULL dereference. > > found by Amit Kulkarni using clang. Okay. > > -- > jake...@sdf.lonestar.org > SDF Public Access UNIX System - htt

Re: fix possible NULL deref in sys/dev/usb/uhub.c

2011-02-18 Thread Mike Belopuhov
On Fri, Feb 18, 2011 at 03:44 +, Jacob Meuser wrote: > at line 190, if nports == 0, 'hub' will be NULL at line 334, and > 'if (hub->ports)' will be a NULL dereference. > > found by Amit Kulkarni using clang. > makes perfect sense. ok mikeb > -- > jake...@sdf.lonestar.org > SDF Public Acce

Re: fix possible NULL deref in sys/dev/usb/uhub.c

2011-02-17 Thread Loganaden Velvindron
Applied on amd64 -current: uhub7 at uhub4 port 1 "ALCOR Generic USB Hub" rev 1.10/3.14 addr 2 Works fine. //Logan C-x-C-c

fix possible NULL deref in sys/dev/usb/uhub.c

2011-02-17 Thread Jacob Meuser
at line 190, if nports == 0, 'hub' will be NULL at line 334, and 'if (hub->ports)' will be a NULL dereference. found by Amit Kulkarni using clang. -- jake...@sdf.lonestar.org SDF Public Access UNIX System - http://sdf.lonestar.org Index: uhub.c ==