Re: httpd: add include_dir keyword

2022-06-04 Thread mfrench
> I do not understand why it is believed that people will generate > better configurations if they split the parts out into different > files. I can not speak for "better" configurations as a result of dividing up the main configuration file. Although I believe it lowers the risk of mistakenly

Re: httpd: add include_dir keyword

2022-06-02 Thread Theo de Raadt
I do not understand why it is believed that people will generate better configurations if they split the parts out into different files. Adding that kind of trick to an already established grammer rarely works well. It only works in narrowly constrained uses of the old grammer, because now one

Re: httpd: add include_dir keyword

2022-06-02 Thread mfrench
Coincidentally I have been working on adding globbing support to include in the httpd config parser. I have only done light testing, nothing in production yet but the patch provided below has not given me any trouble in my test environment yet. Any feedback is welcome! -Matt Index: parse.y

Re: httpd: add include_dir keyword

2022-06-02 Thread Stuart Henderson
On 2022/06/02 12:53, qorg11 wrote: > > I don't think we want this functionality. > > Some users have been asking for it in the #openbsd IRC channel. there are 20+ programs in base which use a config parser derived from the same source as usr/sbin/httpd's, and generally they are kept in sync as

Re: httpd: add include_dir keyword

2022-06-02 Thread qorg11
Ugh, this is awkward. Index: httpd.conf.5 === RCS file: /cvs/src/usr.sbin/httpd/httpd.conf.5,v retrieving revision 1.121 diff -u -p -u -p -r1.121 httpd.conf.5 --- httpd.conf.5 9 Mar 2022 13:50:41 - 1.121 +++ httpd.conf.5 2 Jun

Re: httpd: add include_dir keyword

2022-06-02 Thread qorg11
Ignore that last patch. It has a wrong indentation in an if block. Index: httpd.conf.5 === RCS file: /cvs/src/usr.sbin/httpd/httpd.conf.5,v retrieving revision 1.121 diff -u -p -u -p -r1.121 httpd.conf.5 --- httpd.conf.5 9 Mar 2022

Re: httpd: add include_dir keyword

2022-06-02 Thread qorg11
> I don't think we want this functionality. Some users have been asking for it in the #openbsd IRC channel. In any case, I have fixed the patch file. Index: httpd.conf.5 === RCS file: /cvs/src/usr.sbin/httpd/httpd.conf.5,v

Re: httpd: add include_dir keyword

2022-06-02 Thread Florian Obser
On 2022-06-02 11:04 +02, qorg11 wrote: > This patch addes the "inlcude_dir" keyword for httpd.conf. Which works > just like "include" but it includes all the files in a directory, for > example: include "/etc/httpd.d" > > The diff file is attatched. I don't think we want this functionality.

httpd: add include_dir keyword

2022-06-02 Thread qorg11
This patch addes the "inlcude_dir" keyword for httpd.conf. Which works just like "include" but it includes all the files in a directory, for example: include "/etc/httpd.d" The diff file is attatched. Index: httpd.conf.5 === RCS