Re: ifTypes, if_data->if_type, conflicts and too small

2019-10-18 Thread Iain R. Learmonth
Hi, On 18/10/2019 17:19, Theo de Raadt wrote: >> 3. Track down all the places that this might be used, and make sure they >> are also changed to handle a u_int32_t. > > Gigantic ABI breakage. > > Hope you have fun upgrading bsd, ifconfig, and other tools through that > change. Yeah, I didn't

Re: ifTypes, if_data->if_type, conflicts and too small

2019-10-18 Thread Theo de Raadt
> This presents another problem because the if_type member of the if_data > struct is defined as a u_char and so the type I've been assigned isn't > even going to fit. Riight. > 3. Track down all the places that this might be used, and make sure they > are also changed to handle a u_int32_t.

ifTypes, if_data->if_type, conflicts and too small

2019-10-18 Thread Iain R. Learmonth
Hi, For context: I'm currently working on a patch set for OpenBSD that adds support for AX.25 network interfaces. Constants for interface types are defined in based on the IANA registry for ifTypes maintained as: https://www.iana.org/assignments/ianaiftype-mib As the bottom of this file, we