Re: ifconfig and MPLS: document commands and ioctls, SIOCDELLABEL inconsistency

2021-03-18 Thread Claudio Jeker
On Tue, Mar 16, 2021 at 09:46:27AM +0100, Klemens Nanni wrote: > On Tue, Mar 16, 2021 at 08:55:43AM +0100, Claudio Jeker wrote: > > > .Sh HISTORY > > > -The > > > +The , > > > > Why did you add this ',' that looks strange to me. > > > > > .Nm > > > device first appeared in > > > .Ox 4.4 . >

Re: ifconfig and MPLS: document commands and ioctls, SIOCDELLABEL inconsistency

2021-03-16 Thread Klemens Nanni
On Sat, Mar 13, 2021 at 11:31:05PM +0100, Klemens Nanni wrote: > 3. bug?: mpe(4) does not delete the label upon SIOCDELLABEL: > > # ifconfig mpe > mpe: no such interface > # ifconfig mpe0 create > # ifconfig mpe0 > mpe0: flags=10 mtu 1500 > index 39 pri

Re: ifconfig and MPLS: document commands and ioctls, SIOCDELLABEL inconsistency

2021-03-16 Thread Klemens Nanni
On Tue, Mar 16, 2021 at 08:55:43AM +0100, Claudio Jeker wrote: > > .Sh HISTORY > > -The > > +The , > > Why did you add this ',' that looks strange to me. > > > .Nm > > device first appeared in > > .Ox 4.4 . Fat fingers; fixed now. Index: share/man/man4/mpe.4 ==

Re: ifconfig and MPLS: document commands and ioctls, SIOCDELLABEL inconsistency

2021-03-16 Thread Claudio Jeker
On Tue, Mar 16, 2021 at 12:23:31AM +0100, Klemens Nanni wrote: > On Sat, Mar 13, 2021 at 11:45:30PM +0100, Claudio Jeker wrote: > > On Sat, Mar 13, 2021 at 11:31:05PM +0100, Klemens Nanni wrote: > > > First off: I've never used mpe(4), mpw(4) or mpip(4); this occured to > > > me while looking at i

Re: ifconfig and MPLS: document commands and ioctls, SIOCDELLABEL inconsistency

2021-03-15 Thread Klemens Nanni
On Sat, Mar 13, 2021 at 11:45:30PM +0100, Claudio Jeker wrote: > On Sat, Mar 13, 2021 at 11:31:05PM +0100, Klemens Nanni wrote: > > First off: I've never used mpe(4), mpw(4) or mpip(4); this occured to > > me while looking at ifconfig.{c,8} in general. > > > > > > 1. bug: ifconfig(8) forgets to

Re: ifconfig and MPLS: document commands and ioctls, SIOCDELLABEL inconsistency

2021-03-13 Thread Claudio Jeker
On Sat, Mar 13, 2021 at 11:31:05PM +0100, Klemens Nanni wrote: > First off: I've never used mpe(4), mpw(4) or mpip(4); this occured to > me while looking at ifconfig.{c,8} in general. > > > 1. bug: ifconfig(8) forgets to document both `-tunneldomain' and > `-mplslabel' in the first place, diff b

ifconfig and MPLS: document commands and ioctls, SIOCDELLABEL inconsistency

2021-03-13 Thread Klemens Nanni
First off: I've never used mpe(4), mpw(4) or mpip(4); this occured to me while looking at ifconfig.{c,8} in general. 1. bug: ifconfig(8) forgets to document both `-tunneldomain' and `-mplslabel' in the first place, diff below fixes that. 2. bug: mpe(4) supports SIOCDELLABEL it but the driver m