Re: iked(8): improve logging output

2019-09-25 Thread Alexander Bluhm
On Wed, Sep 25, 2019 at 10:45:50PM +0200, Tobias Heider wrote: > ok? > > @@ -4084,8 +4094,8 @@ ikev2_send_informational(struct iked *en > case IKEV2_N_NO_PROPOSAL_CHOSEN: > break; > default: > - log_debug("%s: unsupported notification %s", __func__, > -

iked(8): improve logging output

2019-09-25 Thread Tobias Heider
A recent commit added the macro SPI_SA which is used to prepend log lines with "spi=0x.." as seen in the message receive and send output. This diff updates the rest of the ikev2.c file to use the new macro. Because I was already fiddling with logging I changed some log_debugs to log_info. Most of

Re: iked(8): improve logging output

2019-08-13 Thread Tobias Heider
On Fri, Aug 09, 2019 at 05:42:30PM +0200, Reyk Floeter wrote: > Hi, > > I agree that __func__ should be removed from anything except log_debug() > messages. > > I think you should prepend the term sa or spi to explain what the hex numbers > mean. > > otherwise OK reyk Thanks! Added with

Re: iked(8): improve logging output

2019-08-09 Thread Reyk Floeter
Hi, I agree that __func__ should be removed from anything except log_debug() messages. I think you should prepend the term sa or spi to explain what the hex numbers mean. otherwise OK reyk > Am 09.08.2019 um 17:31 schrieb Tobias Heider : > > The current log output is not as helpful as i

iked(8): improve logging output

2019-08-09 Thread Tobias Heider
The current log output is not as helpful as i would like it to be, so here's a diff to make it better. This unifies the syntax of the send and recv output, uses the same terms as the configuration (peer and local instead of to and from) and prepends the SAs SPI to each line to make it easier to