Re: make msgsnd(2) more posix

2019-07-18 Thread Ingo Schwarze
Hi Moritz, Moritz Buhl wrote on Thu, Jul 18, 2019 at 01:38:49PM +0200: > bluhm@ wrote: >> Moritz, can you create a man page ERRORS diff? > Is the attached diff ok? Yes, committed with some additional tweaks. Thank you, Ingo CVSROOT:/cvs Module name:src Changes by:

Re: make msgsnd(2) more posix

2019-07-18 Thread Moritz Buhl
> Moritz, can you create a man page ERRORS diff? Is the attached diff ok? mbuhl Index: lib/libc/sys/msgsnd.2 === RCS file: /cvs/src/lib/libc/sys/msgsnd.2,v retrieving revision 1.19 diff -u -p -r1.19 msgsnd.2 ---

Re: make msgsnd(2) more posix

2019-07-17 Thread Alexander Bluhm
On Sun, Jul 14, 2019 at 02:57:54PM +0200, Klemens Nanni wrote: > We also fail to mention that condition in the ERRORS section. Moritz, can you create a man page ERRORS diff? > > - if (msg->msg_type < 0) { > > + if (msg->msg_type <= 0) { > OK kn, although I'd go with `< 1' as that matches the

Re: make msgsnd(2) more posix

2019-07-14 Thread Todd C . Miller
On Sun, 14 Jul 2019 14:57:54 +0200, Klemens Nanni wrote: > What msgsnd(2) send takes should be of type `struct mymsg`, but our > manual page lackes the struct's name, so this could be improved as well. The struct name is intentionally omitted because the standard doesn't specify one. Callers

Re: make msgsnd(2) more posix

2019-07-14 Thread Klemens Nanni
On Fri, Jul 12, 2019 at 10:34:33PM +0200, Moritz Buhl wrote: > while running some ported tests I noticed that msgsnd(2) did not error > when passing a message with mtype < 1, even tho the manual page states: > > mtype is an integer greater than 0 that can be used We also fail to mention that

make msgsnd(2) more posix

2019-07-12 Thread Moritz Buhl
Hi, while running some ported tests I noticed that msgsnd(2) did not error when passing a message with mtype < 1, even tho the manual page states: > mtype is an integer greater than 0 that can be used POSIX says: https://pubs.opengroup.org/onlinepubs/9699919799/ [EINVAL] The value of msqid