Re: mktemp: Clarify error message

2017-12-26 Thread Scott Cheloha
On Tue, Dec 26, 2017 at 12:31:02AM +0100, Klemens Nanni wrote: > On Mon, Dec 25, 2017 at 03:57:00PM -0700, Theo de Raadt wrote: > > I think this is a silly solution, and the documentation is clear > > enough. > The manual page certainly is clear enough but the current error message > is logically

Re: mktemp: Clarify error message

2017-12-26 Thread Marc Espie
On Tue, Dec 26, 2017 at 08:25:50AM +0100, Otto Moerbeek wrote: > > This reminds me of the old IRIX compiler, that would cite complete > parapgraphs of the C standard in error mesasges. Of course logically > it was all correct, but it lead to long and unreadable error messages > that filled up

Re: mktemp: Clarify error message

2017-12-25 Thread Theo de Raadt
>On 12/25/17, Otto Moerbeek wrote: >> On Tue, Dec 26, 2017 at 12:31:02AM +0100, Klemens Nanni wrote: >> >>> On Mon, Dec 25, 2017 at 03:57:00PM -0700, Theo de Raadt wrote: >>> > I think this is a silly solution, and the documentation is clear >>> > enough. >>> The manual page

Re: mktemp: Clarify error message

2017-12-25 Thread Theo de Raadt
>On Mon, Dec 25, 2017 at 03:57:00PM -0700, Theo de Raadt wrote: >> I think this is a silly solution, and the documentation is clear >> enough. >The manual page certainly is clear enough but the current error message >is logically wrong, as there are sufficient Xs *in* `XXs' but just >not at

Re: mktemp: Clarify error message

2017-12-25 Thread patrick keshishian
On 12/25/17, Otto Moerbeek wrote: > On Tue, Dec 26, 2017 at 12:31:02AM +0100, Klemens Nanni wrote: > >> On Mon, Dec 25, 2017 at 03:57:00PM -0700, Theo de Raadt wrote: >> > I think this is a silly solution, and the documentation is clear >> > enough. >> The manual page certainly is

Re: mktemp: Clarify error message

2017-12-25 Thread Otto Moerbeek
On Tue, Dec 26, 2017 at 12:31:02AM +0100, Klemens Nanni wrote: > On Mon, Dec 25, 2017 at 03:57:00PM -0700, Theo de Raadt wrote: > > I think this is a silly solution, and the documentation is clear > > enough. > The manual page certainly is clear enough but the current error message > is logically

Re: mktemp: Clarify error message

2017-12-25 Thread Klemens Nanni
On Mon, Dec 25, 2017 at 03:57:00PM -0700, Theo de Raadt wrote: > I think this is a silly solution, and the documentation is clear > enough. The manual page certainly is clear enough but the current error message is logically wrong, as there are sufficient Xs *in* `XXs' but just not at the end

Re: mktemp: Clarify error message

2017-12-25 Thread Theo de Raadt
I think this is a silly solution, and the documentation is clear enough. How did this happen to you? Show the place where it happened to you. Would the text you propose actually have saved you 1 second of time to help you realize what was wrong? I don't think so. If you weren't familiar that

Re: mktemp: Clarify error message

2017-12-25 Thread Klemens Nanni
On Mon, Dec 25, 2017 at 08:36:07PM +, Stuart Henderson wrote: > On 2017/12/25 20:52, Klemens Nanni wrote: > > from mktemp(1): > > > > The template may be any filename with at least six ‘Xs’ appended > > to it, for example /tmp/tfile.XX. > > > > Now when a template contains

Re: mktemp: Clarify error message

2017-12-25 Thread Stuart Henderson
On 2017/12/25 20:52, Klemens Nanni wrote: > from mktemp(1): > > The template may be any filename with at least six ‘Xs’ appended > to it, for example /tmp/tfile.XX. > > Now when a template contains but does not end in six Xs, the error > message may imply errornous behaviour

mktemp: Clarify error message

2017-12-25 Thread Klemens Nanni
from mktemp(1): The template may be any filename with at least six ‘Xs’ appended to it, for example /tmp/tfile.XX. Now when a template contains but does not end in six Xs, the error message may imply errornous behaviour instead of bad usage: $ mktemp XX