Re: mmap diff for patch(1)

2011-11-13 Thread Michael W. Bombardieri
On Fri, Nov 11, 2011 at 12:02:14PM -0500, Ted Unangst wrote: > I don't see any reason to even open the file if the size is 0. > > On Fri, Nov 11, 2011, Michael W. Bombardieri wrote: > > Sorry, let me try that again... Forgot to clean up file descriptor ifd. > > > > > > Index: inp.c > > =

Re: mmap diff for patch(1)

2011-11-11 Thread Ted Unangst
I don't see any reason to even open the file if the size is 0. On Fri, Nov 11, 2011, Michael W. Bombardieri wrote: > Sorry, let me try that again... Forgot to clean up file descriptor ifd. > > > Index: inp.c > === > RCS file: /usr/s

Re: mmap diff for patch(1)

2011-11-11 Thread Joerg Sonnenberger
On Fri, Nov 11, 2011 at 10:20:19AM +0100, Otto Moerbeek wrote: > On Fri, Nov 11, 2011 at 03:04:28PM +0800, Michael W. Bombardieri wrote: > > > Sorry, let me try that again... Forgot to clean up file descriptor ifd. > > AFAIK, this works without this diff. What problem are you trying to solve? S

Re: mmap diff for patch(1)

2011-11-11 Thread Otto Moerbeek
On Fri, Nov 11, 2011 at 03:04:28PM +0800, Michael W. Bombardieri wrote: > Sorry, let me try that again... Forgot to clean up file descriptor ifd. AFAIK, this works without this diff. What problem are you trying to solve? -Otto > > > Index: inp.c > =

Re: mmap diff for patch(1)

2011-11-10 Thread Michael W. Bombardieri
Sorry, let me try that again... Forgot to clean up file descriptor ifd. Index: inp.c === RCS file: /usr/src/cvs/src/usr.bin/patch/inp.c,v retrieving revision 1.35 diff -u -r1.35 inp.c --- inp.c 27 Oct 2009 23:59:41 - 1

Re: mmap diff for patch(1)

2011-11-10 Thread Michael W. Bombardieri
On Thu, Nov 10, 2011 at 11:10:34PM -0600, Abel Abraham Camarillo Ojeda wrote: > On Thu, Nov 10, 2011 at 9:26 PM, Michael W. Bombardieri wrote: > > Hi tech, > > > > I have a diff for the patch(1) tool which copies > > one included in NetBSD two years ago... > > > > Source: NetBSD src/usr.bin/patch/

Re: mmap diff for patch(1)

2011-11-10 Thread Abel Abraham Camarillo Ojeda
On Thu, Nov 10, 2011 at 9:26 PM, Michael W. Bombardieri wrote: > Hi tech, > > I have a diff for the patch(1) tool which copies > one included in NetBSD two years ago... > > Source: NetBSD src/usr.bin/patch/inp.c revision 1.23 > Purpose: Don't bother mmap'ing an empty file > > Comments/OK? > > - Mi

mmap diff for patch(1)

2011-11-10 Thread Michael W. Bombardieri
Hi tech, I have a diff for the patch(1) tool which copies one included in NetBSD two years ago... Source: NetBSD src/usr.bin/patch/inp.c revision 1.23 Purpose: Don't bother mmap'ing an empty file Comments/OK? - Michael Index: inp.c =