Hi,
Any chance someone could take a look at this, we have written a prometheus
exporter for bgp and ospf, which we would like to share, but it relies on
having this json support in place.
I have re-attached the original diff.
Thanks
Richard
On Mon, Jun 1, 2020 at 7:52 AM Richard Chivers
Hi,
Just a quick bump, wondering if someone could take a look at the diff,
conscious there appears to have been a lot going on recently!
I want to do some more detailed work on the json output, but would
ideally get this first iteration in first.
Richard
On Sat, May 23, 2020 at 9:28 AM Richard
Hi,
I have attached the first iteration of the ospf json support. Sorry
about the large commit,
but it had to come in one go, if we didn't want a broken implementation.
I will go back and update output.c and output_json.c to remove the detail flag
and instead pass through the cli parse_result as
On Mon, May 18, 2020 at 02:46:52PM +0100, Richard Chivers wrote:
> Hi,
>
> Thanks for the feedback, I wasn't happy with the detail flag either, I
> just missed coming back to rethink / change it.
>
> There was a lot of duplicate code i seem to remember, as much of the
> output is sent
Hi,
Thanks for the feedback, I wasn't happy with the detail flag either, I
just missed coming back to rethink / change it.
There was a lot of duplicate code i seem to remember, as much of the
output is sent regardless.
I will take a look over the next couple of days when I get a few
minutes to
On Mon, May 18, 2020 at 09:49:24AM +0200, Denis Fondras wrote:
> On Mon, May 18, 2020 at 09:04:06AM +0200, Claudio Jeker wrote:
> > There is a file missing in the diff.
> >
> > One thing I have seen in the original diff from Richard was that the
> > copyright in the new file should be copied from
On Mon, May 18, 2020 at 09:04:06AM +0200, Claudio Jeker wrote:
> There is a file missing in the diff.
>
> One thing I have seen in the original diff from Richard was that the
> copyright in the new file should be copied from ospfctl.c since this is
> mostly a copy paste action and not new work.
>
On Sun, May 17, 2020 at 04:32:33PM +0200, Denis Fondras wrote:
> On Fri, May 15, 2020 at 11:34:58AM +0100, Richard Chivers wrote:
> > Hi,
> >
> > I have now resolved the spacing/tabbing issues I think correctly
> > following style(9), along with a couple of other indent issues.
> >
> > Would
On Fri, May 15, 2020 at 11:34:58AM +0100, Richard Chivers wrote:
> Hi,
>
> I have now resolved the spacing/tabbing issues I think correctly
> following style(9), along with a couple of other indent issues.
>
> Would appreciate a cursory look at this stage to spot any further common
> issues.
>
Hi,
I have now resolved the spacing/tabbing issues I think correctly
following style(9), along with a couple of other indent issues.
Would appreciate a cursory look at this stage to spot any further common issues.
I have read through style(9) and can't spot anything else, but I may
be missing
On Thu, May 14, 2020 at 07:15:41PM +0100, Richard Chivers wrote:
> Shall I effectively fix issues in the original code at this stage, or only
> where I have moved and refactored?
>
Thanks. Limit the changes to what is relative to json support. The diff is
already big enough :)
Hi,
Sure I will check it out.
Much of the code came directly from ospfctl, so spaces were maintained for
example, I wasn't sure if I should change all lines effectively changing
the original code.
The code originally didn't seem to fully match what I initially read in
style(9).
I will have a
On Thu, May 14, 2020 at 05:51:58PM +0100, Richard Chivers wrote:
> Let me know if this now works for you.
>
This is better, I can apply it :)
However, there are many style(9) issues. Can you fix them please before I review
the changes ?
Thank you.
rks for you.
Thanks
Rich
On Thu, May 14, 2020 at 8:03 AM Denis Fondras wrote:
>
> Please provide a properly formatted diff.
>
> On Thu, May 14, 2020 at 07:16:31AM +0100, Richard Chivers wrote:
> > Hi,
> >
> > I have done the work to implement ospfctl jso
Please provide a properly formatted diff.
On Thu, May 14, 2020 at 07:16:31AM +0100, Richard Chivers wrote:
> Hi,
>
> I have done the work to implement ospfctl json support, but as
> discussed i will provide it in two diffs.
>
> This first one externalises the output
Hi,
I have done the work to implement ospfctl json support, but as
discussed i will provide it in two diffs.
This first one externalises the output aspect of ospfctl and there are
some things like tail that are not needed specifically for straight
standard output, but are required for json
Hi,
Behaviour for certain actions needs discussion and the behaviour crosses over
with the work on bgpctl. A command such as bgpctl -j log brief currently
results in a return such as:
“
Logging request sent.
{
}
"
I think this behaviour would be common to anything which effectively does a
On Mon, May 11, 2020 at 12:38:38PM +0100, Richard Chivers wrote:
> Hi,
>
> I have done some work over the last few days to implement json support
> into ospfctl following the work done recently in bgpctl.
>
> I have some queries, hoping to get some help with.
>
> The change involves a refactor
Hi,
I have done some work over the last few days to implement json support
into ospfctl following the work done recently in bgpctl.
I have some queries, hoping to get some help with.
The change involves a refactor of ospfctl, but reuses the recent
json.c written by Claudio, that is in the
19 matches
Mail list logo
