Re: perldoc: fix man output & formatting

2019-05-05 Thread Ingo Schwarze
Hi Andrew, Andrew Fresh wrote on Sun, May 05, 2019 at 02:44:58PM -0700: > On Sun, May 05, 2019 at 04:53:05PM +0200, Ingo Schwarze wrote: >> The first chunk in the patch below seems to be all that is needed. >> IIRC, we already do a similar thing in pod2man(1). > This is true, we do similar in

Re: perldoc: fix man output & formatting

2019-05-05 Thread Andrew Hewus Fresh
On Sun, May 05, 2019 at 04:53:05PM +0200, Ingo Schwarze wrote: > Hi Andrew, > > Andrew Fresh wrote on Fri, May 03, 2019 at 06:24:16PM -0700: > > > I committed this after moving the waitpid down a few lines, after the > > last read from the filehandle. > > Oops. Sorry for missing that, and

Re: perldoc: fix man output & formatting

2019-05-05 Thread Ingo Schwarze
Hi Andrew, Andrew Fresh wrote on Fri, May 03, 2019 at 06:24:16PM -0700: > I committed this after moving the waitpid down a few lines, after the > last read from the filehandle. Oops. Sorry for missing that, and thanks for committing it, and for catching that additional issue. > I will say

Re: perldoc: fix man output & formatting

2019-05-03 Thread Andrew Hewus Fresh
I committed this after moving the waitpid down a few lines, after the last read from the filehandle. I will say that `perldoc -oterm unicook` looks a lot better with the right fonts and LC_CTYPE=en_US.UTF-8 than the output from -oman, but it looks a lot worse with LC_CTYPE=C so probably -oman is

Re: perldoc: fix man output & formatting

2019-05-03 Thread Todd C . Miller
On Thu, 02 May 2019 21:36:52 -0700, Andrew Hewus Fresh wrote: > In any case, I'll probably commit this slightly cleaned up version > tomorrow as it's to late right now to make sure I didn't clean it too > far. OK millert@ - todd

Re: perldoc: fix man output & formatting

2019-05-02 Thread Andrew Hewus Fresh
On Fri, May 03, 2019 at 04:27:15AM +0200, Ingo Schwarze wrote: > Hi Todd & Andrew, > > Andrew Fresh wrote on Thu, May 02, 2019 at 09:53:29AM -0700: > > On Thu, May 02, 2019 at 10:21:15AM -0600, Todd C. Miller wrote: > >> On Thu, 02 May 2019 10:53:37 -0500, Andrew Daugherity wrote: > > >>> I

Re: perldoc: fix man output & formatting

2019-05-02 Thread Ingo Schwarze
Hi Andrew, Andrew Daugherity wrote on Thu, May 02, 2019 at 10:53:37AM -0500: > Also, their ToMan patch has a previously-included hunk > for MANWIDTH=tty, All that does is suppress a warning message "non-numeric MANWIDTH" when a user has MANWIDTH=tty in their environment. No idea why any user

Re: perldoc: fix man output & formatting

2019-05-02 Thread Ingo Schwarze
Hi Todd & Andrew, Andrew Fresh wrote on Thu, May 02, 2019 at 09:53:29AM -0700: > On Thu, May 02, 2019 at 10:21:15AM -0600, Todd C. Miller wrote: >> On Thu, 02 May 2019 10:53:37 -0500, Andrew Daugherity wrote: >>> I reported this to FreeBSD ports a couple months ago [2], and they >>> provided a

Re: perldoc: fix man output & formatting

2019-05-02 Thread Andrew Hewus Fresh
On Thu, May 02, 2019 at 10:21:15AM -0600, Todd C. Miller wrote: > On Thu, 02 May 2019 10:53:37 -0500, Andrew Daugherity wrote: > > > I reported this to FreeBSD ports a couple months ago [2], and they > > provided a fix [3] which repairs the -oMan output, and makes that the > > default. Their fix

Re: perldoc: fix man output & formatting

2019-05-02 Thread Todd C . Miller
On Thu, 02 May 2019 10:53:37 -0500, Andrew Daugherity wrote: > I reported this to FreeBSD ports a couple months ago [2], and they > provided a fix [3] which repairs the -oMan output, and makes that the > default. Their fix applies cleanly to the OpenBSD tree and works, but > I have no idea why

perldoc: fix man output & formatting

2019-05-02 Thread Andrew Daugherity
After upgrading to 6.5 and thus perl 5.28, the man pages displayed by perldoc (e.g. 'perldoc Digest') or via Perl scripts making use of pod2usage lack formatting such as bold and underlining. In fact, text which used to be underlined is now wrapped in *asterisks* (bold text is just displayed as