Hi Sebastien, Sebastien Marie wrote on Tue, Apr 12, 2016 at 05:09:45PM +0200:
> "mcast" promise isn't documented (used in eigrpd, ldpd, ospfd, and > route6d). > > This promise allows only some options with getsockopt(2)/setsockopt(2): > > - IPV6_MULTICAST_IF : Get or set the interface from which multicast > packets will be sent. > - IPV6_JOIN_GROUP : Join a multicast group > - IPV6_LEAVE_GROUP : Leave a multicast group > > - IP_MULTICAST_IF : same but for ipv4 > - IP_ADD_MEMBERSHIP > - IP_DROP_MEMBERSHIP > > Comments ? A few nits inline. > Index: lib/libc/sys/pledge.2 > =================================================================== > RCS file: /cvs/src/lib/libc/sys/pledge.2,v > retrieving revision 1.29 > diff -u -p -r1.29 pledge.2 > --- lib/libc/sys/pledge.2 12 Apr 2016 12:47:46 -0000 1.29 > +++ lib/libc/sys/pledge.2 12 Apr 2016 15:07:10 -0000 > @@ -297,6 +297,20 @@ domains: > .Pp > .Xr setsockopt 2 > has been reduced in functionality substantially. > +.It Va "mcast" > +Allows to configure an interface from which multicast packets will be sent > and Very minor nit: Maybe break the line a bit earlier. That helps to keep diffs nicer when mailed around. Usually, "!}fmt" without arguments is a nice choice in vi(1). > +to join/leave a multicast group. The following options of Prefer English words to slashes. New sentence, new line: to join or leave a multicast group. The following options of > +.Xr getsockopt 2 > +and > +.Xr setsockopt 2 > +are permitted: > +.Pp > +.Dv IP_MULTICAST_IF , > +.Dv IP_ADD_MEMBERSHIP , > +.Dv IP_DROP_MEMBERSHIP , > +.Dv IPV6_MULTICAST_IF , > +.Dv IPV6_JOIN_GROUP , > +.Dv IPV6_LEAVE_GROUP . Not checking factual accuracy, i trust you on that. Yours, Ingo
