Re: pppoe: move softc list out of NET_LOCK() into new pppoe lock

2020-09-13 Thread Vitaliy Makkoveev
Hello Klemens. pppoe(4) input path and pppoe(4) config path (I mean clone/destroy) is always different context. Your diff introduces the new lock which protects `pppoe_softc_list’ list but what should protect `sc’ you got from this list after you released `pppoe_lock’? I mean this dereference is

Re: pppoe: move softc list out of NET_LOCK() into new pppoe lock

2020-09-13 Thread Martin Pieuchot
On 13/09/20(Sun) 15:12, Klemens Nanni wrote: > This is my first try trading global locks for interface specific ones. > > pppoe(4) keeps a list of all its interfaces which is then obviously > traversed during create and destroy. > > Currently, the net lock is grabbed for this, but there seems to

pppoe: move softc list out of NET_LOCK() into new pppoe lock

2020-09-13 Thread Klemens Nanni
This is my first try trading global locks for interface specific ones. pppoe(4) keeps a list of all its interfaces which is then obviously traversed during create and destroy. Currently, the net lock is grabbed for this, but there seems to be no justification other than reusing^Wabusing an