Re: replace select with poll in libc

2014-10-10 Thread Todd C. Miller
On Fri, 10 Oct 2014 15:17:55 +1000, David Gwynne wrote: > theo made me look at where i was using POLLHUP, so i read your > comment and the poll manpage again. OK millert@ - todd

Re: replace select with poll in libc

2014-10-09 Thread David Gwynne
On Fri, Oct 10, 2014 at 02:42:08PM +1000, David Gwynne wrote: > On Thu, Oct 09, 2014 at 05:36:07AM -0600, Todd C. Miller wrote: > > Two comments inline, otherwise OK. > > like this? > > a couple of people also suggested changing select to poll in the > error messages. theo made me look at where

Re: replace select with poll in libc

2014-10-09 Thread David Gwynne
On Thu, Oct 09, 2014 at 05:36:07AM -0600, Todd C. Miller wrote: > Two comments inline, otherwise OK. like this? a couple of people also suggested changing select to poll in the error messages. Index: net/rcmd.c === RCS file: /cvs/sr

Re: replace select with poll in libc

2014-10-09 Thread Todd C. Miller
Two comments inline, otherwise OK. - todd On Thu, 09 Oct 2014 14:52:50 +1000, David Gwynne wrote: > Index: net/rcmd.c > === > RCS file: /cvs/src/lib/libc/net/rcmd.c,v > retrieving revision 1.56 > diff -u -p -r1.56 rcmd.c > --- net/

Re: replace select with poll in libc

2014-10-08 Thread David Gwynne
On 9 Oct 2014, at 15:11, Bryan Steele wrote: > On Thu, Oct 09, 2014 at 02:52:50PM +1000, David Gwynne wrote: >> this is the only use of select inside libc i could find. it appears >> pretty straightforward to replace with poll. >> >> this compiles, but i have no idea how to test it. >> >> any

Re: replace select with poll in libc

2014-10-08 Thread Bryan Steele
On Thu, Oct 09, 2014 at 02:52:50PM +1000, David Gwynne wrote: > this is the only use of select inside libc i could find. it appears > pretty straightforward to replace with poll. > > this compiles, but i have no idea how to test it. > > any suggestions? or oks? Is rcmd(3) even used by anything a

replace select with poll in libc

2014-10-08 Thread David Gwynne
this is the only use of select inside libc i could find. it appears pretty straightforward to replace with poll. this compiles, but i have no idea how to test it. any suggestions? or oks? Index: net/rcmd.c === RCS file: /cvs/src/lib