Re: rpki-client: get Authority Information Access (AIA) from CA & EE certs

2021-02-15 Thread Claudio Jeker
On Mon, Feb 15, 2021 at 04:58:50PM +, Job Snijders wrote: > Hi, > > Thank you for the review > > On Mon, Feb 15, 2021 at 01:42:57PM +0100, Claudio Jeker wrote: > > Please do not define variables in the middle of functions. > > now fixed > > > > + AUTHORITY_INFO_ACCESS_free(info); > > > +

Re: rpki-client: get Authority Information Access (AIA) from CA & EE certs

2021-02-15 Thread Job Snijders
Hi, Thank you for the review On Mon, Feb 15, 2021 at 01:42:57PM +0100, Claudio Jeker wrote: > Please do not define variables in the middle of functions. now fixed > > + AUTHORITY_INFO_ACCESS_free(info); > > + > > + return aia; > > +} > > I really don't like the way x509_get_aia() is

Re: rpki-client: get Authority Information Access (AIA) from CA & EE certs

2021-02-15 Thread Claudio Jeker
On Sun, Feb 14, 2021 at 05:41:55PM +, Job Snijders wrote: > Make the AIA more easily available for debugging purposes & future > changesets > > In the context of the RPKI, the AIA extension identifies the publication > point of the certificate of the issuer of the certificate in which the >

rpki-client: get Authority Information Access (AIA) from CA & EE certs

2021-02-14 Thread Job Snijders
Make the AIA more easily available for debugging purposes & future changesets In the context of the RPKI, the AIA extension identifies the publication point of the certificate of the issuer of the certificate in which the extension appears. A single reference to the publication point of the