Re: rpki-client unmarshal empty strings as NULL

2020-12-18 Thread Theo Buehler
> This is the next step. I added asserts for strings that must be set and > removed some of complications around optional strings. Especially cert.c > and some of the entityq code benefits from this. Looks good and works for me. ok tb

Re: rpki-client unmarshal empty strings as NULL

2020-12-18 Thread Claudio Jeker
On Fri, Dec 18, 2020 at 05:50:27PM +0100, Theo Buehler wrote: > On Fri, Dec 18, 2020 at 05:45:01PM +0100, Claudio Jeker wrote: > > On Fri, Dec 18, 2020 at 01:46:49PM +0100, Theo Buehler wrote: > > > On Fri, Dec 18, 2020 at 11:43:40AM +0100, Claudio Jeker wrote: > > > > On Wed, Dec 02, 2020 at 05:06

Re: rpki-client unmarshal empty strings as NULL

2020-12-18 Thread Theo Buehler
On Fri, Dec 18, 2020 at 05:45:01PM +0100, Claudio Jeker wrote: > On Fri, Dec 18, 2020 at 01:46:49PM +0100, Theo Buehler wrote: > > On Fri, Dec 18, 2020 at 11:43:40AM +0100, Claudio Jeker wrote: > > > On Wed, Dec 02, 2020 at 05:06:28PM +0100, Claudio Jeker wrote: > > > > rpki-client passes both empt

Re: rpki-client unmarshal empty strings as NULL

2020-12-18 Thread Claudio Jeker
On Fri, Dec 18, 2020 at 01:46:49PM +0100, Theo Buehler wrote: > On Fri, Dec 18, 2020 at 11:43:40AM +0100, Claudio Jeker wrote: > > On Wed, Dec 02, 2020 at 05:06:28PM +0100, Claudio Jeker wrote: > > > rpki-client passes both empty strings and NULL strings as zero length > > > objects. The unmarshal

Re: rpki-client unmarshal empty strings as NULL

2020-12-18 Thread Theo Buehler
On Fri, Dec 18, 2020 at 11:43:40AM +0100, Claudio Jeker wrote: > On Wed, Dec 02, 2020 at 05:06:28PM +0100, Claudio Jeker wrote: > > rpki-client passes both empty strings and NULL strings as zero length > > objects. The unmarshal code then allocates memory in any case and so a > > NULL string is unm

Re: rpki-client unmarshal empty strings as NULL

2020-12-18 Thread Claudio Jeker
On Wed, Dec 02, 2020 at 05:06:28PM +0100, Claudio Jeker wrote: > rpki-client passes both empty strings and NULL strings as zero length > objects. The unmarshal code then allocates memory in any case and so a > NULL string is unmarshalled as empty string. This is not great, currently > there are no

rpki-client unmarshal empty strings as NULL

2020-12-02 Thread Claudio Jeker
rpki-client passes both empty strings and NULL strings as zero length objects. The unmarshal code then allocates memory in any case and so a NULL string is unmarshalled as empty string. This is not great, currently there are no empty strings but a fair amount of NULL strings. This diff changes the