Re: rtentry leak

2014-11-06 Thread Chris Cappuccio
Martin Pieuchot [mpieuc...@nolizard.org] wrote: > > Indeed! And the ifa might also be freed so this chunk is completely > wrong. Here's a version of the diff without it, ok? > This looks ok to me > > Index: net/route.c > === > R

Re: rtentry leak

2014-11-06 Thread Martin Pieuchot
On 05/11/14(Wed) 19:53, Chris Cappuccio wrote: > Martin Pieuchot [mpieuc...@nolizard.org] wrote: > > > > @@ -653,12 +653,12 @@ ifa_ifwithroute(int flags, struct sockad > > struct rtentry *rt = rtalloc(gateway, 0, rtableid); > > if (rt == NULL) > > retur

Re: rtentry leak

2014-11-05 Thread Chris Cappuccio
Martin Pieuchot [mpieuc...@nolizard.org] wrote: > > @@ -653,12 +653,12 @@ ifa_ifwithroute(int flags, struct sockad > struct rtentry *rt = rtalloc(gateway, 0, rtableid); > if (rt == NULL) > return (NULL); > - rt->rt_refcnt--; >

rtentry leak

2014-11-05 Thread Martin Pieuchot
Diff below fixes a rtentry leak in rt_ifa_delloop() and do two other conversions to rtfree(9). While here rename the pool in "rtentry" which makes it easier to understand where to look for leaks. I can commit these chunks separately if needed. ok? Index: n