Re: rtfree(9) and nd6_prefix_{on,off}link

2015-08-18 Thread Martin Pieuchot
On 17/08/15(Mon) 19:24, Alexander Bluhm wrote: > On Mon, Aug 17, 2015 at 07:03:55PM +0200, Martin Pieuchot wrote: > > On 17/08/15(Mon) 18:25, Alexander Bluhm wrote: > > > On Mon, Aug 17, 2015 at 12:34:13PM +0200, Martin Pieuchot wrote: > > > > Ultimately my goal is to use rt_ifa_{add,del}() instead

Re: rtfree(9) and nd6_prefix_{on,off}link

2015-08-18 Thread Alexander Bluhm
On Mon, Aug 17, 2015 at 12:34:13PM +0200, Martin Pieuchot wrote: > Ultimately my goal is to use rt_ifa_{add,del}() instead of > nd6_prefix_{on,off}link() but right now I need to remove the > rt->ref_cnt--. > > This diff does that and reduce the differences between these functions. > > Note that n

Re: rtfree(9) and nd6_prefix_{on,off}link

2015-08-17 Thread Alexander Bluhm
On Mon, Aug 17, 2015 at 07:03:55PM +0200, Martin Pieuchot wrote: > On 17/08/15(Mon) 18:25, Alexander Bluhm wrote: > > On Mon, Aug 17, 2015 at 12:34:13PM +0200, Martin Pieuchot wrote: > > > Ultimately my goal is to use rt_ifa_{add,del}() instead of > > > nd6_prefix_{on,off}link() but right now I nee

Re: rtfree(9) and nd6_prefix_{on,off}link

2015-08-17 Thread Martin Pieuchot
On 17/08/15(Mon) 18:25, Alexander Bluhm wrote: > On Mon, Aug 17, 2015 at 12:34:13PM +0200, Martin Pieuchot wrote: > > Ultimately my goal is to use rt_ifa_{add,del}() instead of > > nd6_prefix_{on,off}link() but right now I need to remove the > > rt->ref_cnt--. > > > @@ -1861,26 +1856,11 @@ nd6_pre

Re: rtfree(9) and nd6_prefix_{on,off}link

2015-08-17 Thread Alexander Bluhm
On Mon, Aug 17, 2015 at 12:34:13PM +0200, Martin Pieuchot wrote: > Ultimately my goal is to use rt_ifa_{add,del}() instead of > nd6_prefix_{on,off}link() but right now I need to remove the > rt->ref_cnt--. > @@ -1861,26 +1856,11 @@ nd6_prefix_onlink(struct nd_prefix *pr) > info.rti_info[RTAX

rtfree(9) and nd6_prefix_{on,off}link

2015-08-17 Thread Martin Pieuchot
Ultimately my goal is to use rt_ifa_{add,del}() instead of nd6_prefix_{on,off}link() but right now I need to remove the rt->ref_cnt--. This diff does that and reduce the differences between these functions. Note that nd6_prefix_onlink()'s error are always logged so I doubt we need two messages.