Re: sensor value last change time not updated?

2020-08-25 Thread Paul de Weerd
On Tue, Aug 25, 2020 at 01:38:20PM -0600, Theo de Raadt wrote: | What you are doing wasn't the purpose of the time field. It was added | only for time sensors, and it looks like someone added it to other | sensors. And now it must suddenly be for all of them?? Sorry - I may have introduced some

Re: sensor value last change time not updated?

2020-08-25 Thread Mark Kettenis
> Date: Tue, 25 Aug 2020 21:33:32 +0200 > From: Paul de Weerd > > Hi Mark, > > Thanks for your reply. > > On Tue, Aug 25, 2020 at 09:27:20PM +0200, Mark Kettenis wrote: > | > I've dug out my stash of weird usb devices and found another sensor (a > | > uthum(4), with only temperature support).

Re: sensor value last change time not updated?

2020-08-25 Thread Theo de Raadt
Paul de Weerd wrote: > On Tue, Aug 25, 2020 at 09:27:20PM +0200, Mark Kettenis wrote: > | > I've dug out my stash of weird usb devices and found another sensor (a > | > uthum(4), with only temperature support). I have a few other sensors > | > in live machines too (acpitz(4), cpu(4),

Re: sensor value last change time not updated?

2020-08-25 Thread Paul de Weerd
Hi Theo, On Tue, Aug 25, 2020 at 01:33:28PM -0600, Theo de Raadt wrote: | > I don't understand the point. None of the sensor drivers set that | > member except the timedelta sensors. I don't think adding code to do | > so to all sensor drivers makes sense. | | That is correct. Non-time

Re: sensor value last change time not updated?

2020-08-25 Thread Theo de Raadt
Mark Kettenis wrote: > > Date: Tue, 25 Aug 2020 21:19:19 +0200 > > From: Paul de Weerd > > > > Hi all, > > > > I've dug out my stash of weird usb devices and found another sensor (a > > uthum(4), with only temperature support). I have a few other sensors > > in live machines too (acpitz(4),

Re: sensor value last change time not updated?

2020-08-25 Thread Paul de Weerd
Hi Mark, Thanks for your reply. On Tue, Aug 25, 2020 at 09:27:20PM +0200, Mark Kettenis wrote: | > I've dug out my stash of weird usb devices and found another sensor (a | > uthum(4), with only temperature support). I have a few other sensors | > in live machines too (acpitz(4), cpu(4),

Re: sensor value last change time not updated?

2020-08-25 Thread Mark Kettenis
> Date: Tue, 25 Aug 2020 21:19:19 +0200 > From: Paul de Weerd > > Hi all, > > I've dug out my stash of weird usb devices and found another sensor (a > uthum(4), with only temperature support). I have a few other sensors > in live machines too (acpitz(4), cpu(4), admtemp(4), it(4), maybe some >

Re: sensor value last change time not updated?

2020-08-25 Thread Paul de Weerd
Hi all, I've dug out my stash of weird usb devices and found another sensor (a uthum(4), with only temperature support). I have a few other sensors in live machines too (acpitz(4), cpu(4), admtemp(4), it(4), maybe some more) that I could look into. Is there any interest in adding support for

Re: sensor value last change time not updated?

2020-08-15 Thread Paul de Weerd
Thanks Hiltjo, that made me look at ugold.c. With the below diff, my simple test program shows a value for the tv struct member. [weerd@pom] $ ./sensor_last_change 1597477798.557355: 28.72 However, given what Hiltjo showed, the tv member seems to only be used for time-sensors, so it may be