Re: split futex into three

2020-04-05 Thread Philip Guenther
On Sun, 5 Apr 2020, Stuart Henderson wrote: > On 2020/04/05 10:28, Martin Pieuchot wrote: > > Another way to proceed would be to do a port grep for futex and see what > > the ecosystem is using. > > Sorry it's not filtered, but : > > https://junkpile.org/grep.futex.gz Sure looks like the only

Re: split futex into three

2020-04-05 Thread Stuart Henderson
On 2020/04/05 10:28, Martin Pieuchot wrote: > Another way to proceed would be to do a port grep for futex and see what > the ecosystem is using. Sorry it's not filtered, but : https://junkpile.org/grep.futex.gz

Re: split futex into three

2020-04-05 Thread Martin Pieuchot
On 04/04/20(Sat) 22:30, Philip Guenther wrote: > [...] > glibc has internal inline functions futex_wait() and futex_wake() and > there has been at least discussion about exporting some version of them. > If our signatures matched the last-best-proposal over there (which was > dropped, mind

Re: split futex into three

2020-04-04 Thread Philip Guenther
On Sat, 4 Apr 2020, Paul Irofti wrote: > Here is a proper diff (both sys and libc into one). Okay, bunch o' comments and thoughts of varying strength of opinion. > diff --git lib/libc/Symbols.list lib/libc/Symbols.list > index f9aa62ab6e8..4fa37a835aa 100644 > --- lib/libc/Symbols.list > +++

Re: split futex into three

2020-04-04 Thread Paul Irofti
Here is a proper diff (both sys and libc into one). diff --git lib/libc/Symbols.list lib/libc/Symbols.list index f9aa62ab6e8..4fa37a835aa 100644 --- lib/libc/Symbols.list +++ lib/libc/Symbols.list @@ -86,7 +86,10 @@ _thread_sys_fstatat _thread_sys_fstatfs _thread_sys_fsync

split futex into three

2020-04-04 Thread Paul Irofti
On Sat, Apr 04, 2020 at 03:53:50PM +0300, Paul Irofti wrote: > > The real problem is that futex(2) is actually 3 different syscalls wrapped > > into one. It was split into three then kdump could properly report > > futex_wake(2) and futex_requeue(2) as returning a count, while > >