Re: tcpdump gtp bugfix

2020-05-19 Thread David Gwynne
> On 20 May 2020, at 1:31 am, Miod Vallat wrote: > > There seems to be a logic error in tcpdump's print-gtp.c. > > The code is printing some values by passing a pointer to the array of > strings, and the index within the array, and the routine uses > sizeof(array) / sizeof(array[0]) to

tcpdump gtp bugfix

2020-05-19 Thread Miod Vallat
There seems to be a logic error in tcpdump's print-gtp.c. The code is printing some values by passing a pointer to the array of strings, and the index within the array, and the routine uses sizeof(array) / sizeof(array[0]) to figure out the bound. But since the caller is passing a pointer,