Re: ticks usage in USB drivers

2016-04-12 Thread Jonathan Gray
On Tue, Apr 12, 2016 at 09:38:53AM +0200, Martin Pieuchot wrote: > On 12/04/16(Tue) 17:16, Jonathan Gray wrote: > > On Thu, Apr 07, 2016 at 04:45:43PM +0200, Martin Pieuchot wrote: > > > On 07/04/16(Thu) 22:29, Jonathan Gray wrote: > > > > On Thu, Apr 07, 2016 at 01:47:13PM +0200, Martin Pieuchot w

Re: ticks usage in USB drivers

2016-04-12 Thread Martin Pieuchot
On 12/04/16(Tue) 17:16, Jonathan Gray wrote: > On Thu, Apr 07, 2016 at 04:45:43PM +0200, Martin Pieuchot wrote: > > On 07/04/16(Thu) 22:29, Jonathan Gray wrote: > > > On Thu, Apr 07, 2016 at 01:47:13PM +0200, Martin Pieuchot wrote: > > > > If we need a random value to fake an Ethernet address, let'

Re: ticks usage in USB drivers

2016-04-12 Thread Jonathan Gray
On Thu, Apr 07, 2016 at 04:45:43PM +0200, Martin Pieuchot wrote: > On 07/04/16(Thu) 22:29, Jonathan Gray wrote: > > On Thu, Apr 07, 2016 at 01:47:13PM +0200, Martin Pieuchot wrote: > > > If we need a random value to fake an Ethernet address, let's use > > > arc4random(9). > > > > > > ok? > > > >

Re: ticks usage in USB drivers

2016-04-07 Thread Martin Pieuchot
On 07/04/16(Thu) 22:29, Jonathan Gray wrote: > On Thu, Apr 07, 2016 at 01:47:13PM +0200, Martin Pieuchot wrote: > > If we need a random value to fake an Ethernet address, let's use > > arc4random(9). > > > > ok? > > You missed if_cdce.c which uses 0x2acb as well but uses microuptime. Updated dif

Re: ticks usage in USB drivers

2016-04-07 Thread Jonathan Gray
On Thu, Apr 07, 2016 at 01:47:13PM +0200, Martin Pieuchot wrote: > If we need a random value to fake an Ethernet address, let's use > arc4random(9). > > ok? You missed if_cdce.c which uses 0x2acb as well but uses microuptime. Why can't these all just use ether_fakeaddr() ? > > Index: if_cdcef.

ticks usage in USB drivers

2016-04-07 Thread Martin Pieuchot
If we need a random value to fake an Ethernet address, let's use arc4random(9). ok? Index: if_cdcef.c === RCS file: /cvs/src/sys/dev/usb/if_cdcef.c,v retrieving revision 1.41 diff -u -p -r1.41 if_cdcef.c --- if_cdcef.c 25 Nov 2015 0