Re: try to map 64-bit mem space first

2018-04-10 Thread Ted Unangst
Mark Kettenis wrote: > We should allways use mmio instead of io if possible. The cascading > if statements are a bit ugly, but I can't come up with a better solution. mapped = 0; if (pcimap() == 0) mapped = 1; if (!mapped && pcimap() == 0)

Re: try to map 64-bit mem space first

2018-04-09 Thread Mike Larkin
On Mon, Apr 09, 2018 at 08:27:49PM +0200, Mark Kettenis wrote: > > Date: Mon, 9 Apr 2018 18:31:49 +0200 > > From: Patrick Wildt > > > > Hi, > > > > some (probably newer) re(4) cards don't have the 32-bit memory BAR that > > we try to map first. Instead there's a 64-bit

Re: try to map 64-bit mem space first

2018-04-09 Thread Mark Kettenis
> Date: Mon, 9 Apr 2018 18:31:49 +0200 > From: Patrick Wildt > > Hi, > > some (probably newer) re(4) cards don't have the 32-bit memory BAR that > we try to map first. Instead there's a 64-bit memory BAR in the follow- > ing BAR. On the MacchiatoBIN, where we currently do

re(4): try to map 64-bit mem space first

2018-04-09 Thread Patrick Wildt
Hi, some (probably newer) re(4) cards don't have the 32-bit memory BAR that we try to map first. Instead there's a 64-bit memory BAR in the follow- ing BAR. On the MacchiatoBIN, where we currently do not support the IO space, this means we need to attempt to map the 64-bit memory BAR. This