Re: ttymalloc(int baud)

2020-05-26 Thread Theo de Raadt
The decision to allocate more storage is decided by an unexpected usage pattern we encountered after the API was designed, which isn't immediately obvious from the device name... Some of these devices are designed for high-speed PPP. Some of them (in particular on USB) actually move bytes faster

ttymalloc(int baud)

2020-05-26 Thread johnc
Another trivial code readability comment: I see 24 references to this in the code, 20 of which pass 0, and 4 of which pass 1,000,000 as the parameter. Passing 0 defaults to a baud of 115200. The baud determines the qlen, which is 4096 for 115200 and 8192 for anything larger, so all it is doing n