Re: usr.sbin/ospf6d: fix -Wunused-but-set-variable warnings

2022-01-19 Thread Claudio Jeker
On Mon, Jan 17, 2022 at 02:54:32PM +0100, Christian Weisgerber wrote: > usr.sbin/ospf6d: fix -Wunused-but-set-variable warnings > > merge_config() sets "rchange", but doesn't use it. Comparing the > code to osfpd/ospfd.c makes me think that's an omission. Either > way

Re: usr.sbin/ospf6d: fix -Wunused-but-set-variable warnings

2022-01-17 Thread Denis Fondras
Le Mon, Jan 17, 2022 at 02:25:27PM +, Stuart Henderson a écrit : > On 2022/01/17 14:54, Christian Weisgerber wrote: > > usr.sbin/ospf6d: fix -Wunused-but-set-variable warnings > > > > merge_config() sets "rchange", but doesn't use it. Comparing the > >

Re: usr.sbin/ospf6d: fix -Wunused-but-set-variable warnings

2022-01-17 Thread Stuart Henderson
On 2022/01/17 14:54, Christian Weisgerber wrote: > usr.sbin/ospf6d: fix -Wunused-but-set-variable warnings > > merge_config() sets "rchange", but doesn't use it. Comparing the > code to osfpd/ospfd.c makes me think that's an omission. Either > way it seems odd that

usr.sbin/ospf6d: fix -Wunused-but-set-variable warnings

2022-01-17 Thread Christian Weisgerber
usr.sbin/ospf6d: fix -Wunused-but-set-variable warnings merge_config() sets "rchange", but doesn't use it. Comparing the code to osfpd/ospfd.c makes me think that's an omission. Either way it seems odd that the two code bases differ here. rde_summary_update() is incomplete. We