bge(4): do not malloc(9) ring memory in bge_init()

2014-05-23 Thread Martin Pieuchot
Diff below splits the functions that allocate memory for the various ring to do it only once, in bge_attach(), instead of doing it every time bge_init() is called, possibly in the watchdog function. Tested with a Broadcom BCM5714 rev 0xa3, BCM5715 A3 (0x9003). Comments? Ok? Index: if_bge.c

Re: pckbd volume keys (part 1), diff to test

2014-05-23 Thread Alexandre Ratchov
On Wed, Apr 30, 2014 at 01:06:48AM +0200, Alexandre Ratchov wrote: This diff attempts to unify volume keys; it makes pckbd and ukbd volume keys behave like all other volume keys (acpithinkpad, acpiasus, macppc/abtn and similar drivers): simply adjust the hardware volume without passing

gettytab(5) typo fix (and clearing console on (auto-)logout)

2014-05-23 Thread Jean-Philippe Ouellet
Found while trying to figure out how to be sure the console is always cleared at logout (and the resulting login prompt seemed like a pretty guaranteed-to-always-work place). If you have a cleaner way, perhaps one that is actually at logout and doesn't involve missing all the startup messages due

Re: [PATCH] libssl:Remove NULL checks before calling free()

2014-05-23 Thread Brendan MacDonell
I think this can be extended to expressions, not just identifiers: @@ expression x; @@ -if (x) { free(x); } +free(x); This catches another 47 instances. A patch against CVS follows. diff -u -p a/src/apps/s_server.c b/src/apps/s_server.c --- a/src/apps/s_server.c +++

Re: [PATCH] libssl:Remove NULL checks before calling free()

2014-05-23 Thread Cyril Roelandt
On 05/23/2014 09:29 PM, Brendan MacDonell wrote: I think this can be extended to expressions, not just identifiers: @@ expression x; @@ -if (x) { free(x); } +free(x); Yes you are right. Shame on me. Regards, Cyril Roelandt.