Re: KASSERT() @ pf_test() is back

On 08/02/16(Mon) 01:55, Alexandr Nedvedicky wrote: > Hello, > > I don't expect to see O.K. to patch below. > > The patch is the part of the change, which has been backed out last weekend. > Too many things were wrong so I'm trying to untangle the code a bit. > > Patch below is for brave hearts,

The Case of Lost TM_ZONE

It looks like decided to use TM_ZONE as a wrapper for tm.tm_zone, until the tm_zone is gone. So, until the later happens (I found no usage of tm_zone in base, BTW), we should at least use TM_ZONE consistently. Okay for the patch? Or should I proceed to the TM_ZONE removal together with next libc

Re: socppc/fdt: convert big endian to host endian

On 20/02/16(Sat) 01:45, Patrick Wildt wrote: > Hi, > > FDT is spread widely in the embedded market. Especially those ARM > machines make heavy use of it. FDT is always stored in big endian, > like socppc. To be able to use this code on little endian machines, > like those ARMs, this diff

Re: more windows versions for acpi _OSI checks

> Date: Sun, 28 Feb 2016 16:07:50 +1100 > From: Jonathan Gray > > Claim to be more versions of windows for _OSI. Mostly based on the > table in 'How to Identify the Windows Version in ACPI by Using _OSI'. > > 2001.1 SP1Windows Server 2003 SP1 > 2006.1Windows

read(2) shouldn't return EFBIG

The ext2fs_read() and ffs_read() functions return EFBIG when uio_offset if smaller than zero or larger than the maxium file size. However this doesn't seem to be in accordance with the POSIX read(2) specification, which requires EINVAL for an invalid offset (< 2) and a return of 0 (zero bytes

move ckqueue function to common.c

This moves essentially identical ckqueue functions out of lpd.c and lpq.c into common_source/common.c. Builds without errors on i386. lpq and lpd work afterwards Index: lpq.c === RCS file: /cvs/src/usr.sbin/lpr/lpq/lpq.c,v

RTL8188EE pcidevs code

Found on a recent-model HP laptop. -David Index: pcidevs === RCS file: /cvs/src/sys/dev/pci/pcidevs,v retrieving revision 1.1788 diff -u -p -r1.1788 pcidevs --- pcidevs 20 Feb 2016 14:34:27 - 1.1788 +++ pcidevs 28

Re: x86 BPTTRAP

On 28 February 2016 at 14:38, Martin Pieuchot wrote: > In order to dynamically instrument kernel functions, I plan to add > breakpoints where a probe needs to be executed. Trap handlers will > be modified to check if the address of the trapping instruction > correspond to a

socppc/fdt: fix end signature check (again)

Hi, unfortunately the end signature check is still not correct. Consulting the spec cleared the confusion of why the check does not work on my ARM machines. The FDT tree contains a "structure block". The FDT header contains information, on which offset that block starts. Since version 17 of

Re: tmpfs improvements

On Sat, Feb 27, 2016 at 05:44:49PM -0500, Michael McConville wrote: > * There wasn't yet a list of possible errors for tmpfs in mount(2). >That said, I question the value of maintaining these lists. It's >almost impossible for them to be comprehensive - for example, some >*_mount()

Re: read(2) shouldn't return EFBIG

Martin Pieuchot wrote: > On 28/02/16(Sun) 13:14, Martin Natano wrote: > > The ext2fs_read() and ffs_read() functions return EFBIG when uio_offset > > if smaller than zero or larger than the maxium file size. However this > > doesn't seem to be in accordance with the POSIX read(2) specification, >

Re: read(2) shouldn't return EFBIG

Stefan Kempf wrote: > Martin Pieuchot wrote: > > On 28/02/16(Sun) 13:14, Martin Natano wrote: > > > The ext2fs_read() and ffs_read() functions return EFBIG when uio_offset > > > if smaller than zero or larger than the maxium file size. However this > > > doesn't seem to be in accordance with the

Re: [patch] add UTF-8 support to column(1)

> > - Replace tabs between columns with spaces. > > I'm not convinced that should be changed. In any case, it is unrelated > to UTF-8. I suspect changing tabs to spaces will break a lot of scripts.

Re: [patch] add UTF-8 support to column(1)

Hi I don't know why it is off in xterm but oxtabs is the default in ttydefaults.h and appears to on for mostly everything else, including ssh and tmux (which just uses what forkpty gives it). Hi Martijn, Martijn van Duren wrote on Sat, Feb 27, 2016 at 01:22:53PM +0100: > Here's my attempt to

x86 BPTTRAP

In order to dynamically instrument kernel functions, I plan to add breakpoints where a probe needs to be executed. Trap handlers will be modified to check if the address of the trapping instruction correspond to a registered probe, and if that's the case, the kernel will execute the associated

socppc/fdt: fix fdt_find_node for the case we don't find a node

Hi, If we're calling fdt_find_node() and do not actually find the node we're looking for, we call strncmp with a NULL value. What happens is that we use fdt_child_node(node) to retrieve a child and then use fdt_next_node(child) to go through the list of children. If we do not find a child that

Re: [patch] add UTF-8 support to column(1)

Hi Nicholas, Nicholas Marriott wrote on Sun, Feb 28, 2016 at 04:21:15PM +: > I don't know why it is off in xterm but oxtabs is the default in > ttydefaults.h and appears to on for mostly everything else, > including ssh and tmux (which just uses what forkpty gives it). That means that even

Re: properly inject UDP header for udpencap over IPv6

On Fri, Feb 26, 2016 at 21:55 +0100, Patrick Wildt wrote: > On Fri, Feb 26, 2016 at 08:25:02PM +0100, Alexander Bluhm wrote: > > On Fri, Feb 26, 2016 at 04:56:49PM +0100, Mike Belopuhov wrote: > > > I think your revised diff should be committed. Any objections? > > > > OK bluhm@ > > > > > >

Re: x86 BPTTRAP

On 28/02/16(Sun) 17:02, Mike Belopuhov wrote: > On 28 February 2016 at 14:38, Martin Pieuchot wrote: > > In order to dynamically instrument kernel functions, I plan to add > > breakpoints where a probe needs to be executed. Trap handlers will > > be modified to check if the

zaurus: disentangle zboot from compat/linux

This disentangles the zaurus bootstrap from compat/linux. We only need a small subset of syscall numbers and constants, so this moves the definitions directly into zboot/compat_linux.h. Compared to compat/linux/*.h, I skipped various intermediate typedefs and defines. It's silly to have half of

Re: read(2) shouldn't return EFBIG

On 28/02/16(Sun) 13:14, Martin Natano wrote: > The ext2fs_read() and ffs_read() functions return EFBIG when uio_offset > if smaller than zero or larger than the maxium file size. However this > doesn't seem to be in accordance with the POSIX read(2) specification, > which requires EINVAL for an

Re: [patch] add UTF-8 support to column(1)

Hi Martijn, Martijn van Duren wrote on Sat, Feb 27, 2016 at 01:22:53PM +0100: > Here's my attempt to implement UTF-8 support in column(1). > Besides the general UTF-8 conversions it does several other things > to make it behave properly. Two general remarks: 1. This column(1) code seems to be

Re: rtadvd: remove more dead code

j...@wxcvbn.org (Jeremie Courreges-Anglas) writes: > Alexander Bluhm writes: > >> On Tue, Feb 09, 2016 at 02:17:18AM +0100, J??r??mie Courr??ges-Anglas wrote: >>> >>> - a few *cnt members of struct rainfo aren't used for anything >>> - the SIOCGIFPREFIX_IN6 ioctl has

Switch to uiomove in usb

This changes uiomovei calls to uiomove in usb. It fixes a few integer truncations due to use of min, and uses unsigned types for count variables where it makes sense. This also allows us to get rid of a couple of 'if (len < 0)' checks that just cannot happen. udbd_get_cdesc() returns a length

rdist.c patch

--- rdist.c.origSun Feb 28 15:29:27 2016 +++ rdist.cSun Feb 28 15:32:06 2016 @@ -57,8 +57,7 @@ char *path_remsh = NULL; static void addhostlist(char *, struct namelist **); -static void usage(void); -int main(int, char **, char **); +__dead void usage(void); /* * Add a

Re: move ckqueue function to common.c - tweaked and proper diff

Index: usr.sbin/lpr/common_source/common.c === RCS file: /cvs/src/usr.sbin/lpr/common_source/common.c,v retrieving revision 1.40 diff -u -p -r1.40 common.c --- usr.sbin/lpr/common_source/common.c 12 Jan 2016 23:35:13 - 1.40

systrace: drop Linux emulation support

This diff removes the Linux emulation support from the systrace command. The changes are very much mechanical. This is the last userland part that references compat/linux. Also, these files bin/systrace/linux-translate.c bin/systrace/linux-translate.h bin/systrace/linux_socketcall.h can

Re: read(2) shouldn't return EFBIG

On Sun, Feb 28, 2016 at 04:40:21PM +0100, Stefan Kempf wrote: > Stefan Kempf wrote: > > Martin Pieuchot wrote: > > > I'm also wondering when you say "an offset that's at or paste the > > > EOF" does that include ``uio_resid''? I mean shouldn't you check > > > for: > > > > > > if

Re: rtadvd: remove more dead code

On Sun, Feb 28, 2016 at 12:16:12AM +0100, Jeremie Courreges-Anglas wrote: > Alexander Bluhm writes: > > OK bluhm@ > > > > I think you should also kill the function init_prefix() and move > > the remaining 4 lines into make_prefix() in another diff. > > duh, thanks.

Re: move ckqueue function to common.c

On Sun, Feb 28, 2016 at 09:55:37AM -0600, Chris Bennett wrote: > This moves essentially identical ckqueue functions out of lpd.c and > lpq.c into common_source/common.c. > Builds without errors on i386. lpq and lpd work afterwards > ok tb@ modulo two comments: > > Index: lp.h >

remove unusued copy_non_glob in ksh

No binary change. -David Index: eval.c === RCS file: /cvs/src/bin/ksh/eval.c,v retrieving revision 1.49 diff -u -p -r1.49 eval.c --- eval.c 30 Dec 2015 09:07:00 - 1.49 +++ eval.c 29 Feb 2016 00:54:42 - @@

Remove last kernel references to compat

This diff * copies the stackgap_init() and stackgap_alloc() functions from compat/common/compat_util.c to dev/systrace.c, the one place they are used, * removes the remaining kernel references to compat/*. Once the zboot and systrace diffs are in, this will allow all of compat/common/* and

Re: socppc/fdt: fix fdt_find_node for the case we don't find a node

Hi Patrick, On Sun, 28 Feb 2016, Patrick Wildt wrote: > Hi, > > If we're calling fdt_find_node() and do not actually find the node we're > looking for, we call strncmp with a NULL value. > [...] Tested on RB600A: boots fine, dmesg unchanged (mod banner). Patch applied to HEAD, fdt.c:1.12.

Re: socppc/fdt: fix end signature check (again)

Hi Patrick, On Sun, 28 Feb 2016, Patrick Wildt wrote: > Hi, > > unfortunately the end signature check is still not correct. Consulting > the spec cleared the confusion of why the check does not work on my ARM > machines. > [...] Tested on RB600A: boots fine, dmesg unchanged (mod banner).

Re: rtadvd: remove more dead code

j...@wxcvbn.org (Jeremie Courreges-Anglas) writes: > j...@wxcvbn.org (Jeremie Courreges-Anglas) writes: > >> Alexander Bluhm writes: >> >>> On Tue, Feb 09, 2016 at 02:17:18AM +0100, J??r??mie Courr??ges-Anglas wrote: - a few *cnt members of struct rainfo