Re: ifconfig(8): require specification of address family

> At the moment ifconfig(8) sets address of `inet` family if no > address family specified and some unrecognized parameter given. > This has security and UX implications: Security? Oh really? It seems these days nearly everything gets labelled as security, trying to get us to rise up. >

relayd: 6.1-stable and relay_http.c rev 1.58

Hey, with rev 1.58 OPTIONS in relay_http.c got broken or at least logic inside relay_read_http(). Quick fix it to cre->toread=0 and break, but this is probably not what should be there. In my test case, from the client side I do an OPTIONS request, followed by a couple of GET. GET in the middle

Re: Enable TCP selective acknowledgements (SACK) on all kernels

On Sun, Oct 22, 2017 at 11:23 +0200, Job Snijders wrote: > On Thu, Oct 19, 2017 at 06:55:05PM +0200, Mike Belopuhov wrote: > > SACK has been enabled in GENERIC kernels for over a decade and it's > > time to make it an official part of the TCP stack. > > I tested your diff by doing an amd64

ifconfig(8): require specification of address family

At the moment ifconfig(8) sets address of `inet` family if no address family specified and some unrecognized parameter given. This has security and UX implications: Because inet addresses mix with other ifconfig(8) parameters, a misspelled parameter will be assumed to be an inet address. Since it

clang: Avoid EBX/RBX

Hello tech@, The attached diff changes the order in which clang will allocate registers on X86, specifically so EBX / RBX are selected last. The reason is because some instructions using RBX as the destination operand and either RAX or RCX as the source result in machine code that includes a C3

Re: relayd: 6.1-stable and relay_http.c rev 1.58

> 22 okt. 2017 kl. 20:16 skrev Maxim Bourmistrov : > > Hey, > with rev 1.58 OPTIONS in relay_http.c got broken > or at least logic inside relay_read_http(). > Quick fix it to cre->toread=0 and break, but this is probably not what should > be there. > > In my test case,

Re: Enable TCP selective acknowledgements (SACK) on all kernels

On Thu, Oct 19, 2017 at 06:55:05PM +0200, Mike Belopuhov wrote: > SACK has been enabled in GENERIC kernels for over a decade and it's > time to make it an official part of the TCP stack. I tested your diff by doing an amd64 release build and testing both the newly created /bsd and /bsd.rd, I

remove defines for unimplemented ioctls

Index: sys/net80211/ieee80211_ioctl.h === RCS file: /cvs/src/sys/net80211/ieee80211_ioctl.h,v retrieving revision 1.29 diff -u -p -r1.29 ieee80211_ioctl.h --- sys/net80211/ieee80211_ioctl.h 19 Jul 2017 22:04:46 - 1.29

refill msk(4) rx ring from a timeout when there's no mbufs

if msk runs out of mbufs, the rx ring remains empty and there's nothing except an ifconfig down and up to get it going again. this adds a timeout to refill the ring. it's largely copied from other drivers (vr in this case). tests? ok? Index: if_mskvar.h

Re: tftpd(8): diff for ip path rewrite

I agree with this more. Also, the previous patch had + if (access(nfilename, R_OK) == 0) + tftp_open(client, nfilename); Which means if the directory is writeable by something else up the server side, you have TOCTOU. Never check if you can open, then open.

Re: tftpd(8): diff for ip path rewrite

On Sat, Oct 21 2017, Jan Klemkow wrote: > On Fri, Oct 20, 2017 at 12:04:41PM +, Jeremie Courreges-Anglas wrote: >> On Fri, Oct 20 2017, Sebastien Marie wrote: >> > On Thu, Oct 19, 2017 at 08:58:12PM +0200, Jan Klemkow wrote: >> >> + char