Re: vmd: add minimal DHCP support

2017-11-02 Thread Carlos Cardenas
On 11/02/17 14:26, Reyk Floeter wrote: Hi, the problem got reported a few times and a similar diff was floating around: vmd's "local interface" implements a simple auto-magic BOOTP server, but udhcpc doesn't support BOOTP, which is the predecessor and a valid subset of DHCP. udhcpc is used by

[PATCH] VMD: remove debug message in proc

2017-11-02 Thread Carlos Cardenas
This debug message has served its duty for finding bugs in shutdown related issues. Ok reyk@ diff --git usr.sbin/vmd/proc.c usr.sbin/vmd/proc.c index afa9b223649..d223d6bcce2 100644 --- usr.sbin/vmd/proc.c +++ usr.sbin/vmd/proc.c @@ -756,8 +756,6 @@ proc_compose_imsg(struct privsep *ps, enum

[PATCH 1/2 v2] VMD: remove add from switch configuration

2017-11-02 Thread Carlos Cardenas
Remove configuration items on switches for: * adding static interfaces Adding static interfaces are to be set in hostname.if. Changed rule on rdomain: * vm->interface->rdomain takes precedence over sw->rdomain Update examples/vm.conf and vm.conf manpage to reflect changes. Comments? Ok? diff

[PATCH 2/2 v2] VMD: regress tests update for switch configuration

2017-11-02 Thread Carlos Cardenas
Update regression tests to match new switch configuration diff --git regress/usr.sbin/vmd/config/Makefile regress/usr.sbin/vmd/config/Makefile index 2adc69ae491..3bf124aff56 100644 --- regress/usr.sbin/vmd/config/Makefile +++ regress/usr.sbin/vmd/config/Makefile @@ -5,7 +5,7 @@ VMD ?=

[PATCH 0/2 v2] VMD: switch configuration changes

2017-11-02 Thread Carlos Cardenas
This patch series makes the following changes to switch configuration: * Removes adding static interfaces (done in /etc/hostname.if) * vm->interface->rdomain take precedence over sw->rdomain Updated regression tests to match vm.conf changes. Updated examples/vm.conf to match vm.conf changes.

merge nd6_rs_input() and nd6_ra_input()

2017-11-02 Thread Florian Obser
We are processing Router Solicitation / Advertisement messages only for the Source Link-layer Address Options. Merge nd6_rs_input() and nd6_ra_input() into one generic function. OK? diff --git netinet6/icmp6.c netinet6/icmp6.c index 421280690c9..b5e12169584 100644 --- netinet6/icmp6.c +++

vmd: add minimal DHCP support

2017-11-02 Thread Reyk Floeter
Hi, the problem got reported a few times and a similar diff was floating around: vmd's "local interface" implements a simple auto-magic BOOTP server, but udhcpc doesn't support BOOTP, which is the predecessor and a valid subset of DHCP. udhcpc is used by busybox and many embedded Linux

Re: [PATCH 1/2] VMD: complete switch configuration overhaul

2017-11-02 Thread Reyk Floeter
On Thu, Nov 02, 2017 at 10:53:52AM -0700, Carlos Cardenas wrote: > Removed configuration items on switches for: > * adding interfaces > * setting group > * setting rdomain > > All of these items are now to be set in hostname.if and are > queried by vmd for propagation to the vm's vif(s). > >

[PATCH 0/2] VMD: complete switch configuration overhaul

2017-11-02 Thread Carlos Cardenas
This patch series finishes up the switch configuration to be handled in hostname.if change. It removes from switch configuration in vm.conf: * adding interfaces (done in /etc/hostname.if) * setting group(s) (done in /etc/hostname.if) * setting rdomain (don in /etc/hostname.if) vmd now queries

[PATCH 1/2] VMD: complete switch configuration overhaul

2017-11-02 Thread Carlos Cardenas
Removed configuration items on switches for: * adding interfaces * setting group * setting rdomain All of these items are now to be set in hostname.if and are queried by vmd for propagation to the vm's vif(s). Update example vm.conf and vm.conf manpage to reflect changes. Comments? Ok? diff

[PATCH 2/2] VMD: regress tests update for switch configuration

2017-11-02 Thread Carlos Cardenas
Update regression tests to match new switch configuration diff --git regress/usr.sbin/vmd/config/Makefile regress/usr.sbin/vmd/config/Makefile index 2adc69ae491..a337b816acc 100644 --- regress/usr.sbin/vmd/config/Makefile +++ regress/usr.sbin/vmd/config/Makefile @@ -5,7 +5,8 @@ VMD ?=

tedu raw_cb.c

2017-11-02 Thread Florian Obser
This inlines all the trivial functions in the various places. OK? diff --git sys/conf/files sys/conf/files index 03b4a0e24cc..2771b6f4446 100644 --- sys/conf/files +++ sys/conf/files @@ -788,7 +788,6 @@ file net/switchctl.cswitch file net/switchofp.c

tedu raw_disconnect()

2017-11-02 Thread Florian Obser
There is no way SS_NOFDREF is set on a raw socket in raw_usrreq for PRU_DISCONNECT or PRU_ABORT. So raw_disconnect() and sofree() return immediately so remove the dead code. Also the following call to soisdisconnected() would be a use after free. This removes the last calls to raw_disconnect()

Re: kevent(2) EVFILT_USER support

2017-11-02 Thread Paul Irofti
On Thu, Nov 02, 2017 at 01:50:01PM +, Stuart Henderson wrote: > On 2017/11/02 14:29, Paul Irofti wrote: > > Here is a backport from FreeBSD to support EVFILT_USER events. > > I can't comment on whether or not this should be added, but if it is, some > ports > will pick it up and need bumps:

Re: libfuse: fuse.c null checks and others

2017-11-02 Thread Martin Pieuchot
On 28/10/17(Sat) 13:57, Helg Bredow wrote: > [...] > I've reverted fuse_loop_mt(). However, I don't feel that this is correct. If > a file system expects it to work then it should fail to make it clear that > the functionality is not implemented. sshfs calls it but because >

Re: kevent(2) EVFILT_USER support

2017-11-02 Thread Stuart Henderson
On 2017/11/02 14:29, Paul Irofti wrote: > Here is a backport from FreeBSD to support EVFILT_USER events. I can't comment on whether or not this should be added, but if it is, some ports will pick it up and need bumps: devel/libinotify devel/libivykis net/ntp sysutils/syslog-ng telephony/asterisk

Re: kevent(2) EVFILT_USER support

2017-11-02 Thread Mark Kettenis
> Date: Thu, 2 Nov 2017 14:29:30 +0200 > From: Paul Irofti > > Hi, > > Here is a backport from FreeBSD to support EVFILT_USER events. > > %--- > EVFILT_USEREstablishes a user event identified by

Re: kevent(2) EVFILT_USER support

2017-11-02 Thread Paul Irofti
> Reducing kqueue(2) differences is IMHO good since it makes easier to > port 3rd party software. However you forgot to mention why you want > this. Which ports make use of that? None at the moment. I am currently porting libudev from FreeBSD that makes use of it. > Do FreeBSD has regression

Re: kevent(2) EVFILT_USER support

2017-11-02 Thread Martin Pieuchot
On 02/11/17(Thu) 14:29, Paul Irofti wrote: > Hi, > > Here is a backport from FreeBSD to support EVFILT_USER events. > [...] > I can split the diff in two if needed: first add the touch > functionality and then the EVFILT_USER support on top. > > Thoughts? Reducing kqueue(2) differences is IMHO

Re: move PRU_DETACH out of pr_usrreq

2017-11-02 Thread Martin Pieuchot
On 02/11/17(Thu) 09:06, Florian Obser wrote: > this moves PRU_DETACH out of pr_usrreq into per proto pr_detach > functions, like what claudio did to pr_attach. > > Intentionally mostly mechanical. There might be some cleanup here and > there in the functions themselves. I like it, comments

kevent(2) EVFILT_USER support

2017-11-02 Thread Paul Irofti
Hi, Here is a backport from FreeBSD to support EVFILT_USER events. %--- EVFILT_USER Establishes a user event identified by ident which is not associated with any kernel mechanism but is trig-

Re: [PATCH] etc/ksh.kshrc - unify command substitution

2017-11-02 Thread Raf Czlonka
Hi all, So there's one OK - anyone else? Would anyone be so kind as to commit it, please? :^) Regards, Raf On Mon, Oct 23, 2017 at 06:32:03PM BST, Alexander Hall wrote: > I'm OK with this. > > /Alexander > > > On October 23, 2017 3:29:57 PM GMT+02:00, Raf Czlonka >

move PRU_DETACH out of pr_usrreq

2017-11-02 Thread Florian Obser
this moves PRU_DETACH out of pr_usrreq into per proto pr_detach functions, like what claudio did to pr_attach. Intentionally mostly mechanical. There might be some cleanup here and there in the functions themselves. OK? diff --git kern/uipc_proto.c kern/uipc_proto.c index